Re: [PATCH] intel_menlow: prevent NULL pointer dereference

2016-06-09 Thread Darren Hart
On Thu, Jun 09, 2016 at 07:24:52PM +0200, Vincent Stehlé wrote: > On Wed, Jun 08, 2016 at 01:38:46PM -0700, Darren Hart wrote: > > Under what circumstances can the .remove op be called with a NULL struct > > acpi_device * as a parameter? From what I can see, most acpi_* calls > > accpeting > > an

Re: [PATCH] intel_menlow: prevent NULL pointer dereference

2016-06-09 Thread Darren Hart
On Thu, Jun 09, 2016 at 07:24:52PM +0200, Vincent Stehlé wrote: > On Wed, Jun 08, 2016 at 01:38:46PM -0700, Darren Hart wrote: > > Under what circumstances can the .remove op be called with a NULL struct > > acpi_device * as a parameter? From what I can see, most acpi_* calls > > accpeting > > an

Re: [PATCH] intel_menlow: prevent NULL pointer dereference

2016-06-09 Thread Vincent Stehlé
On Wed, Jun 08, 2016 at 01:38:46PM -0700, Darren Hart wrote: > Under what circumstances can the .remove op be called with a NULL struct > acpi_device * as a parameter? From what I can see, most acpi_* calls accpeting > an acpi_device rely on it not being null, and they are regularly called from >

Re: [PATCH] intel_menlow: prevent NULL pointer dereference

2016-06-09 Thread Vincent Stehlé
On Wed, Jun 08, 2016 at 01:38:46PM -0700, Darren Hart wrote: > Under what circumstances can the .remove op be called with a NULL struct > acpi_device * as a parameter? From what I can see, most acpi_* calls accpeting > an acpi_device rely on it not being null, and they are regularly called from >

Re: [PATCH] intel_menlow: prevent NULL pointer dereference

2016-06-08 Thread Darren Hart
On Wed, May 25, 2016 at 04:20:11PM +0200, Vincent Stehlé wrote: > The function acpi_driver_data() will dereference its parameter; make sure > to check for NULL pointer before we call it. +Rafael Under what circumstances can the .remove op be called with a NULL struct acpi_device * as a

Re: [PATCH] intel_menlow: prevent NULL pointer dereference

2016-06-08 Thread Darren Hart
On Wed, May 25, 2016 at 04:20:11PM +0200, Vincent Stehlé wrote: > The function acpi_driver_data() will dereference its parameter; make sure > to check for NULL pointer before we call it. +Rafael Under what circumstances can the .remove op be called with a NULL struct acpi_device * as a

[PATCH] intel_menlow: prevent NULL pointer dereference

2016-05-25 Thread Vincent Stehlé
The function acpi_driver_data() will dereference its parameter; make sure to check for NULL pointer before we call it. Signed-off-by: Vincent Stehlé Cc: Sujith Thomas Cc: Darren Hart Cc: Zhang Rui

[PATCH] intel_menlow: prevent NULL pointer dereference

2016-05-25 Thread Vincent Stehlé
The function acpi_driver_data() will dereference its parameter; make sure to check for NULL pointer before we call it. Signed-off-by: Vincent Stehlé Cc: Sujith Thomas Cc: Darren Hart Cc: Zhang Rui Cc: Len Brown --- drivers/platform/x86/intel_menlow.c | 8 ++-- 1 file changed, 6