Re: [PATCH] io: Fix return type of _inb and _inl

2020-07-27 Thread Arnd Bergmann
On Mon, Jul 27, 2020 at 10:30 AM John Garry wrote: > On 27/07/2020 09:04, Arnd Bergmann wrote:> On Sun, Jul 26, 2020 at 2:53 > PM Stafford Horne wrote: > >> > >> On Sun, Jul 26, 2020 at 12:00:37PM +0300, Andy Shevchenko wrote: > >>> On Sun, Jul 26, 2020 at 6:14 AM Stafford Horne wrote: > >

Re: [PATCH] io: Fix return type of _inb and _inl

2020-07-27 Thread John Garry
On 27/07/2020 09:04, Arnd Bergmann wrote:> On Sun, Jul 26, 2020 at 2:53 PM Stafford Horne wrote: On Sun, Jul 26, 2020 at 12:00:37PM +0300, Andy Shevchenko wrote: On Sun, Jul 26, 2020 at 6:14 AM Stafford Horne wrote: The return type of functions _inb, _inw and _inl are all u16 which looks

Re: [PATCH] io: Fix return type of _inb and _inl

2020-07-27 Thread Arnd Bergmann
On Sun, Jul 26, 2020 at 2:53 PM Stafford Horne wrote: > > On Sun, Jul 26, 2020 at 12:00:37PM +0300, Andy Shevchenko wrote: > > On Sun, Jul 26, 2020 at 6:14 AM Stafford Horne wrote: > > > > > > The return type of functions _inb, _inw and _inl are all u16 which looks > > > wrong. This patch makes

Re: [PATCH] io: Fix return type of _inb and _inl

2020-07-26 Thread Stafford Horne
On Sun, Jul 26, 2020 at 12:00:37PM +0300, Andy Shevchenko wrote: > On Sun, Jul 26, 2020 at 6:14 AM Stafford Horne wrote: > > > > The return type of functions _inb, _inw and _inl are all u16 which looks > > wrong. This patch makes them u8, u16 and u32 respectively. > > > > The original commit

Re: [PATCH] io: Fix return type of _inb and _inl

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 6:14 AM Stafford Horne wrote: > > The return type of functions _inb, _inw and _inl are all u16 which looks > wrong. This patch makes them u8, u16 and u32 respectively. > > The original commit text for these does not indicate that these should > be all forced to u16. Is

[PATCH] io: Fix return type of _inb and _inl

2020-07-25 Thread Stafford Horne
The return type of functions _inb, _inw and _inl are all u16 which looks wrong. This patch makes them u8, u16 and u32 respectively. The original commit text for these does not indicate that these should be all forced to u16. Fixes: f009c89df79a ("io: Provide _inX() and _outX()") Signed-off-by: