Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Christoph Hellwig
On Fri, Jul 19, 2019 at 03:16:55PM +0900, Masahiro Yamada wrote: > > headers-$(CONFIG_IOMAP) += iomap.h > > I cannot find CONFIG_IOMAP. > > Do you mean > > header-test-$(CONFIG_BLOCK) += iomap.h Yeah, we could use CONFIG_BLOCK.

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Masahiro Yamada
On Fri, Jul 19, 2019 at 2:59 PM Christoph Hellwig wrote: > > On Fri, Jul 19, 2019 at 11:19:15AM +0900, Masahiro Yamada wrote: > > I started to think > > compiling all headers is more painful than useful. > > > > > > MW is closing, so I am thinking of disabling it for now > > to take time to re-thi

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Christoph Hellwig
On Fri, Jul 19, 2019 at 11:19:15AM +0900, Masahiro Yamada wrote: > I started to think > compiling all headers is more painful than useful. > > > MW is closing, so I am thinking of disabling it for now > to take time to re-think. For now this seems like the best idea. In the long run maybe we ca

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Masahiro Yamada
On Fri, Jul 19, 2019 at 11:24 AM Randy Dunlap wrote: > > On 7/18/19 7:19 PM, Masahiro Yamada wrote: > > Hi. > > > > On Thu, Jul 18, 2019 at 11:28 PM Darrick J. Wong > > wrote: > >> > >> On Thu, Jul 18, 2019 at 03:08:35PM +0200, Christoph Hellwig wrote: > >>> On Thu, Jul 18, 2019 at 03:03:15PM +02

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Randy Dunlap
On 7/18/19 7:19 PM, Masahiro Yamada wrote: > Hi. > > On Thu, Jul 18, 2019 at 11:28 PM Darrick J. Wong > wrote: >> >> On Thu, Jul 18, 2019 at 03:08:35PM +0200, Christoph Hellwig wrote: >>> On Thu, Jul 18, 2019 at 03:03:15PM +0200, Arnd Bergmann wrote: The inclusion comes from the recently add

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Masahiro Yamada
Hi. On Thu, Jul 18, 2019 at 11:28 PM Darrick J. Wong wrote: > > On Thu, Jul 18, 2019 at 03:08:35PM +0200, Christoph Hellwig wrote: > > On Thu, Jul 18, 2019 at 03:03:15PM +0200, Arnd Bergmann wrote: > > > The inclusion comes from the recently added header check in commit > > > c93a0368aaa2 ("kbuil

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Arnd Bergmann
On Thu, Jul 18, 2019 at 3:08 PM Christoph Hellwig wrote: > > On Thu, Jul 18, 2019 at 03:03:15PM +0200, Arnd Bergmann wrote: > > The inclusion comes from the recently added header check in commit > > c93a0368aaa2 ("kbuild: do not create wrappers for header-test-y"). > > > > This just tries to inclu

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Darrick J. Wong
On Thu, Jul 18, 2019 at 03:08:35PM +0200, Christoph Hellwig wrote: > On Thu, Jul 18, 2019 at 03:03:15PM +0200, Arnd Bergmann wrote: > > The inclusion comes from the recently added header check in commit > > c93a0368aaa2 ("kbuild: do not create wrappers for header-test-y"). > > > > This just tries

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Christoph Hellwig
On Thu, Jul 18, 2019 at 03:03:15PM +0200, Arnd Bergmann wrote: > The inclusion comes from the recently added header check in commit > c93a0368aaa2 ("kbuild: do not create wrappers for header-test-y"). > > This just tries to include every header by itself to see if there are build > failures from m

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Arnd Bergmann
On Thu, Jul 18, 2019 at 2:57 PM Christoph Hellwig wrote: > > On Thu, Jul 18, 2019 at 02:55:01PM +0200, Arnd Bergmann wrote: > > When CONFIG_BLOCK is disabled, SECTOR_SHIFT is unknown: > > > > In file included from :3: > > include/linux/iomap.h:76:48: error: use of undeclared identifier > > 'SECTO

Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Christoph Hellwig
On Thu, Jul 18, 2019 at 02:55:01PM +0200, Arnd Bergmann wrote: > When CONFIG_BLOCK is disabled, SECTOR_SHIFT is unknown: > > In file included from :3: > include/linux/iomap.h:76:48: error: use of undeclared identifier > 'SECTOR_SHIFT' > return (iomap->addr + pos - iomap->offset) >> SECTOR

[PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

2019-07-18 Thread Arnd Bergmann
When CONFIG_BLOCK is disabled, SECTOR_SHIFT is unknown: In file included from :3: include/linux/iomap.h:76:48: error: use of undeclared identifier 'SECTOR_SHIFT' return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT; Since there are no callers in this case, just hide the function in