Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-11 Thread Al Viro
On Sun, Feb 11, 2007 at 05:45:33PM +0100, Martin Schwidefsky wrote: > On Sat, 2007-02-10 at 23:55 +, Al Viro wrote: > > FWIW, the current picture wrt io-related stuff looks so: > > > > s390: no ioport_map, no ioread*/iowrite*, no port IO except for > > (in|out)b(_p|) > > s390 does not even

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-11 Thread Martin Schwidefsky
On Sat, 2007-02-10 at 23:55 +, Al Viro wrote: > FWIW, the current picture wrt io-related stuff looks so: > > s390: no ioport_map, no ioread*/iowrite*, no port IO except for (in|out)b(_p|) s390 does not even need (in|out)b(_p|). I wondered what else from io.h do we not need. The answer is:

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-11 Thread Martin Schwidefsky
On Sat, 2007-02-10 at 23:55 +, Al Viro wrote: FWIW, the current picture wrt io-related stuff looks so: s390: no ioport_map, no ioread*/iowrite*, no port IO except for (in|out)b(_p|) s390 does not even need (in|out)b(_p|). I wondered what else from io.h do we not need. The answer is:

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-11 Thread Al Viro
On Sun, Feb 11, 2007 at 05:45:33PM +0100, Martin Schwidefsky wrote: On Sat, 2007-02-10 at 23:55 +, Al Viro wrote: FWIW, the current picture wrt io-related stuff looks so: s390: no ioport_map, no ioread*/iowrite*, no port IO except for (in|out)b(_p|) s390 does not even need

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Al Viro
On Sat, Feb 10, 2007 at 05:14:13PM -0500, Tejun Heo wrote: > Heiko Carstens wrote: > >On Sat, Feb 10, 2007 at 12:43:16PM -0500, Tejun Heo wrote: > \>> Heiko, how about this? Does it fix s390? > > > >Unfortunately not. Now I get > > > > CC lib/iomap.o > >lib/iomap.c: In function

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Randy Dunlap
On Sat, 10 Feb 2007 12:43:16 -0500 Tejun Heo wrote: > devres iomap made lib/iomap.c always built and added several > arch-indep PCI routines to include/linux/io.h and lib/iomap.c without > wrapping them inside CONFIG_PCI. This breaks configurations where PCI > is not configured. Wrap

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Heiko Carstens
On Sat, Feb 10, 2007 at 05:14:13PM -0500, Tejun Heo wrote: > Heiko Carstens wrote: > >On Sat, Feb 10, 2007 at 12:43:16PM -0500, Tejun Heo wrote: > \>> Heiko, how about this? Does it fix s390? > >Unfortunately not. Now I get > > CC lib/iomap.o > >lib/iomap.c: In function

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Al Viro
On Sat, Feb 10, 2007 at 10:50:33PM +, Al Viro wrote: > We don't even require ioremap(). What the hell could it possibly mean on > e.g. UML? The same goes for DMA. And yes, of course it means that a lot > of drivers are not buildable on it - hardly a surprise, that... FWIW, the current

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Al Viro
On Sat, Feb 10, 2007 at 02:25:53PM -0800, Linus Torvalds wrote: > > > On Sat, 10 Feb 2007, Tejun Heo wrote: > > > > I think an arch needs to support ioport_map/unmap and noncoherent dma (just > > alias to coherent interface on x86/amd64) interface whether PCI is > > implemented > > or not.

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Linus Torvalds
On Sat, 10 Feb 2007, Tejun Heo wrote: > > I think an arch needs to support ioport_map/unmap and noncoherent dma (just > alias to coherent interface on x86/amd64) interface whether PCI is implemented > or not. No? We haven't required ioport implementations in the past, afaik.

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Tejun Heo
Heiko Carstens wrote: On Sat, Feb 10, 2007 at 12:43:16PM -0500, Tejun Heo wrote: \>> Heiko, how about this? Does it fix s390? Unfortunately not. Now I get CC lib/iomap.o lib/iomap.c: In function 'devm_ioport_map_release': lib/iomap.c:270: warning: implicit declaration of function

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Heiko Carstens
On Sat, Feb 10, 2007 at 12:43:16PM -0500, Tejun Heo wrote: > devres iomap made lib/iomap.c always built and added several > arch-indep PCI routines to include/linux/io.h and lib/iomap.c without > wrapping them inside CONFIG_PCI. This breaks configurations where PCI > is not configured. Wrap

[PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Tejun Heo
devres iomap made lib/iomap.c always built and added several arch-indep PCI routines to include/linux/io.h and lib/iomap.c without wrapping them inside CONFIG_PCI. This breaks configurations where PCI is not configured. Wrap pci_iomap() in CONFIG_PCI and move managed PCI iomap functions into

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Tejun Heo
Heiko Carstens wrote: On Sat, Feb 10, 2007 at 12:43:16PM -0500, Tejun Heo wrote: \ Heiko, how about this? Does it fix s390? Unfortunately not. Now I get CC lib/iomap.o lib/iomap.c: In function 'devm_ioport_map_release': lib/iomap.c:270: warning: implicit declaration of function

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Linus Torvalds
On Sat, 10 Feb 2007, Tejun Heo wrote: I think an arch needs to support ioport_map/unmap and noncoherent dma (just alias to coherent interface on x86/amd64) interface whether PCI is implemented or not. No? We haven't required ioport implementations in the past, afaik.

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Al Viro
On Sat, Feb 10, 2007 at 02:25:53PM -0800, Linus Torvalds wrote: On Sat, 10 Feb 2007, Tejun Heo wrote: I think an arch needs to support ioport_map/unmap and noncoherent dma (just alias to coherent interface on x86/amd64) interface whether PCI is implemented or not. No? We

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Al Viro
On Sat, Feb 10, 2007 at 10:50:33PM +, Al Viro wrote: We don't even require ioremap(). What the hell could it possibly mean on e.g. UML? The same goes for DMA. And yes, of course it means that a lot of drivers are not buildable on it - hardly a surprise, that... FWIW, the current picture

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Heiko Carstens
On Sat, Feb 10, 2007 at 05:14:13PM -0500, Tejun Heo wrote: Heiko Carstens wrote: On Sat, Feb 10, 2007 at 12:43:16PM -0500, Tejun Heo wrote: \ Heiko, how about this? Does it fix s390? Unfortunately not. Now I get CC lib/iomap.o lib/iomap.c: In function 'devm_ioport_map_release':

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Randy Dunlap
On Sat, 10 Feb 2007 12:43:16 -0500 Tejun Heo wrote: devres iomap made lib/iomap.c always built and added several arch-indep PCI routines to include/linux/io.h and lib/iomap.c without wrapping them inside CONFIG_PCI. This breaks configurations where PCI is not configured. Wrap pci_iomap() in

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Al Viro
On Sat, Feb 10, 2007 at 05:14:13PM -0500, Tejun Heo wrote: Heiko Carstens wrote: On Sat, Feb 10, 2007 at 12:43:16PM -0500, Tejun Heo wrote: \ Heiko, how about this? Does it fix s390? Unfortunately not. Now I get CC lib/iomap.o lib/iomap.c: In function 'devm_ioport_map_release':

[PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Tejun Heo
devres iomap made lib/iomap.c always built and added several arch-indep PCI routines to include/linux/io.h and lib/iomap.c without wrapping them inside CONFIG_PCI. This breaks configurations where PCI is not configured. Wrap pci_iomap() in CONFIG_PCI and move managed PCI iomap functions into

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Heiko Carstens
On Sat, Feb 10, 2007 at 12:43:16PM -0500, Tejun Heo wrote: devres iomap made lib/iomap.c always built and added several arch-indep PCI routines to include/linux/io.h and lib/iomap.c without wrapping them inside CONFIG_PCI. This breaks configurations where PCI is not configured. Wrap