Re: [PATCH] iommu/mediatek: always enable the clk on resume

2021-04-16 Thread Joerg Roedel
On Fri, Apr 16, 2021 at 03:47:01PM +0200, Dafna Hirschfeld wrote: > Hi, > I sent v2, removing the word 'comment' from the 'Fixes' tag > after a problem report from Stephen Rothwell, > could you replace v1 with v2? Replaced it, thanks.

Re: [PATCH] iommu/mediatek: always enable the clk on resume

2021-04-16 Thread Dafna Hirschfeld
Hi, I sent v2, removing the word 'comment' from the 'Fixes' tag after a problem report from Stephen Rothwell, could you replace v1 with v2? Thanks, Dafna On 15.04.21 15:34, Joerg Roedel wrote: On Thu, Apr 08, 2021 at 02:28:42PM +0200, Dafna Hirschfeld wrote: drivers/iommu/mtk_iommu.c | 19

Re: [PATCH] iommu/mediatek: always enable the clk on resume

2021-04-15 Thread Joerg Roedel
On Thu, Apr 08, 2021 at 02:28:42PM +0200, Dafna Hirschfeld wrote: > drivers/iommu/mtk_iommu.c | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) Applied, thanks.

Re: [PATCH] iommu/mediatek: always enable the clk on resume

2021-04-09 Thread Yong Wu
On Thu, 2021-04-08 at 14:28 +0200, Dafna Hirschfeld wrote: > In mtk_iommu_runtime_resume always enable the clk, even > if m4u_dom is null. Otherwise the 'suspend' cb might > disable the clk which is already disabled causing the warning: Hi Dafna, Thanks very much for testing and report. I have

[PATCH] iommu/mediatek: always enable the clk on resume

2021-04-08 Thread Dafna Hirschfeld
In mtk_iommu_runtime_resume always enable the clk, even if m4u_dom is null. Otherwise the 'suspend' cb might disable the clk which is already disabled causing the warning: [1.586104] infra_m4u already disabled [1.586133] WARNING: CPU: 0 PID: 121 at drivers/clk/clk.c:952