Re: [PATCH] iommu: arm-smmu: correct sid to mask

2017-04-25 Thread Joerg Roedel
On Mon, Apr 24, 2017 at 04:54:54PM +0100, Will Deacon wrote: > On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote: > > - sid, smmu->smr_mask_mask); > > + mask, smmu->smr_mask_mask); > > goto out_free; > > Looks like a

Re: [PATCH] iommu: arm-smmu: correct sid to mask

2017-04-25 Thread Joerg Roedel
On Mon, Apr 24, 2017 at 04:54:54PM +0100, Will Deacon wrote: > On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote: > > - sid, smmu->smr_mask_mask); > > + mask, smmu->smr_mask_mask); > > goto out_free; > > Looks like a

Re: [PATCH] iommu: arm-smmu: correct sid to mask

2017-04-24 Thread Will Deacon
On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote: > From code "SMR mask 0x%x out of range for SMMU", > so, we need to use mask, not sid. > > Signed-off-by: Peng Fan > Cc: Will Deacon > Cc: Robin Murphy > --- >

Re: [PATCH] iommu: arm-smmu: correct sid to mask

2017-04-24 Thread Will Deacon
On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote: > From code "SMR mask 0x%x out of range for SMMU", > so, we need to use mask, not sid. > > Signed-off-by: Peng Fan > Cc: Will Deacon > Cc: Robin Murphy > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH] iommu: arm-smmu: correct sid to mask

2017-04-21 Thread Peng Fan
>From code "SMR mask 0x%x out of range for SMMU", so, we need to use mask, not sid. Signed-off-by: Peng Fan Cc: Will Deacon Cc: Robin Murphy --- drivers/iommu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] iommu: arm-smmu: correct sid to mask

2017-04-21 Thread Peng Fan
>From code "SMR mask 0x%x out of range for SMMU", so, we need to use mask, not sid. Signed-off-by: Peng Fan Cc: Will Deacon Cc: Robin Murphy --- drivers/iommu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c