Re: [PATCH] iosched: Add i10 I/O Scheduler

2021-01-11 Thread Rachit Agarwal
[Resending the last message] Happy 2021 everyone! > Dear all: > > Hope you are all well. > > Sagi and I were wondering if you have any additional feedback on the > updated patch? (@Ming?) We have been receiving a lot of > interest/questions from industry on incorporation of i10 in the > kernel. If

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-30 Thread Sagi Grimberg
Dear all: Thanks, again, for the very constructive decisions. I am writing back with quite a few updates: 1. We have now included a detailed comparison of i10 scheduler with Kyber with NVMe-over-TCP (https://github.com/i10-kernel/upstream-linux/blob/master/i10-evaluation.pdf). In a nutshe

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-16 Thread Ming Lei
On Fri, Nov 13, 2020 at 01:36:16PM -0800, Sagi Grimberg wrote: > > > > But if you think this has a better home, I'm assuming that the guys > > > will be open to that. > > > > Also see the reply from Ming. It's a balancing act - don't want to add > > extra overhead to the core, but also don't want

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-13 Thread Sagi Grimberg
But if you think this has a better home, I'm assuming that the guys will be open to that. Also see the reply from Ming. It's a balancing act - don't want to add extra overhead to the core, but also don't want to carry an extra scheduler if the main change is really just variable dispatch batc

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-13 Thread Jens Axboe
On 11/13/20 2:36 PM, Sagi Grimberg wrote: > >>> But if you think this has a better home, I'm assuming that the guys >>> will be open to that. >> >> Also see the reply from Ming. It's a balancing act - don't want to add >> extra overhead to the core, but also don't want to carry an extra >> schedul

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-13 Thread Jens Axboe
On 11/13/20 2:23 PM, Sagi Grimberg wrote: > I haven't taken a close look at the code yet so far, but one quick note that patches like this should be against the branches for 5.11. In fact, this one doesn't even compile against current -git, as blk_mq_bio_list_merge is now calle

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-13 Thread Sagi Grimberg
But if you think this has a better home, I'm assuming that the guys will be open to that. Also see the reply from Ming. It's a balancing act - don't want to add extra overhead to the core, but also don't want to carry an extra scheduler if the main change is really just variable dispatch batc

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-13 Thread Sagi Grimberg
I haven't taken a close look at the code yet so far, but one quick note that patches like this should be against the branches for 5.11. In fact, this one doesn't even compile against current -git, as blk_mq_bio_list_merge is now called blk_bio_list_merge. Ugh, I guess that Jaehyun had this pa

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-13 Thread Jens Axboe
On 11/13/20 1:34 PM, Sagi Grimberg wrote: > >> I haven't taken a close look at the code yet so far, but one quick note >> that patches like this should be against the branches for 5.11. In fact, >> this one doesn't even compile against current -git, as >> blk_mq_bio_list_merge is now called blk_bi

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-13 Thread Sagi Grimberg
blk-mq actually has built-in batching(or sort of) mechanism, which is enabled if the hw queue is busy(hctx->dispatch_busy is > 0). We use EWMA to compute hctx->dispatch_busy, and it is adaptive, even though the implementation is quite coarse. But there should be much space to improve, IMO. Yo

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-13 Thread Sagi Grimberg
I haven't taken a close look at the code yet so far, but one quick note that patches like this should be against the branches for 5.11. In fact, this one doesn't even compile against current -git, as blk_mq_bio_list_merge is now called blk_bio_list_merge. Ugh, I guess that Jaehyun had this pa

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-13 Thread Ming Lei
Hello, On Thu, Nov 12, 2020 at 09:07:52AM -0500, Rachit Agarwal wrote: > From: Rachit Agarwal > > > Hi All, > > I/O batching is beneficial for optimizing IOPS and throughput for various > applications. For instance, several kernel block drivers would benefit from > batching, > including mmc [1]

Re: [PATCH] iosched: Add i10 I/O Scheduler

2020-11-12 Thread Jens Axboe
On 11/12/20 7:07 AM, Rachit Agarwal wrote: > From: Rachit Agarwal > > > Hi All, > > I/O batching is beneficial for optimizing IOPS and throughput for > various applications. For instance, several kernel block drivers would > benefit from batching, including mmc [1] and tcp-based storage drivers >

[PATCH] iosched: Add i10 I/O Scheduler

2020-11-12 Thread Rachit Agarwal
From: Rachit Agarwal > Hi All, I/O batching is beneficial for optimizing IOPS and throughput for various applications. For instance, several kernel block drivers would benefit from batching, including mmc [1] and tcp-based storage drivers like nvme-tcp [2,3]. While we have support for batching