Re: [PATCH] ipack: add missing put_device() after device_register() failed

2013-02-27 Thread Samuel Iglesias Gonsálvez
Hello Dmitry, First of all, thanks for your comments. On 02/26/2013 11:28 PM, Dmitry Torokhov wrote: > On Tue, Feb 26, 2013 at 10:03:15AM +0100, Samuel Iglesias Gonsalvez wrote: >> put_device() must be called after device_register() fails, >> since device_register() always initializes the refcoun

Re: [PATCH] ipack: add missing put_device() after device_register() failed

2013-02-26 Thread Dmitry Torokhov
On Tue, Feb 26, 2013 at 10:03:15AM +0100, Samuel Iglesias Gonsalvez wrote: > put_device() must be called after device_register() fails, > since device_register() always initializes the refcount > on the device structure to one. > > dev->id is free'd inside of ipack_device_release function. > So, i

[PATCH] ipack: add missing put_device() after device_register() failed

2013-02-26 Thread Samuel Iglesias Gonsalvez
put_device() must be called after device_register() fails, since device_register() always initializes the refcount on the device structure to one. dev->id is free'd inside of ipack_device_release function. So, it's not needed to do it here. Signed-off-by: Samuel Iglesias Gonsalvez --- drivers/i