Re: [PATCH] ipc,msg: shorten critical region in msgsnd

2013-09-12 Thread Manfred Spraul
Hi all, On 09/12/2013 02:20 PM, Manfred Spraul wrote: And: What about the other users of obtain_object_check? exit_sem() is also quite long, but I didn't spot any obvious problems. a) I think semtimed(), msgsnd() and msgrcv() must be fixed: They either leak memory or tasks can sleep forever.

Re: [PATCH] ipc,msg: shorten critical region in msgsnd

2013-09-12 Thread Manfred Spraul
Hi Davidlohr, I think the patch (3dd1f784ed6603d7ab1043e51e6371235edf2313) is still unsafe, i.e. my correction (bebcb928c820d0ee83aca4b192adc195e43e66a2) doesn't fix everything: AFAICS, ipc_obtain_object_check: - look up the id in the idr tree - check if it is deleted - return without taking

Re: [PATCH] ipc,msg: shorten critical region in msgsnd

2013-09-12 Thread Manfred Spraul
Hi Davidlohr, I think the patch (3dd1f784ed6603d7ab1043e51e6371235edf2313) is still unsafe, i.e. my correction (bebcb928c820d0ee83aca4b192adc195e43e66a2) doesn't fix everything: AFAICS, ipc_obtain_object_check: - look up the id in the idr tree - check if it is deleted - return without taking

Re: [PATCH] ipc,msg: shorten critical region in msgsnd

2013-09-12 Thread Manfred Spraul
Hi all, On 09/12/2013 02:20 PM, Manfred Spraul wrote: And: What about the other users of obtain_object_check? exit_sem() is also quite long, but I didn't spot any obvious problems. a) I think semtimed(), msgsnd() and msgrcv() must be fixed: They either leak memory or tasks can sleep forever.