Re: [RESEND PATCH] ipmi: Clear drvdata when interface is removed by hotmod

(2014/09/10 3:17), Corey Minyard wrote: > Ok, I can see the problem. Instead of the change you have, can you add > something like: > > if (!info) > return; > if (info->dev) > dev_set_drvdata(info->dev, NULL); > > to the top of cleanup_one_si() instead? I think that would be a

Re: [RESEND PATCH] ipmi: Clear drvdata when interface is removed by hotmod

Ok, I can see the problem. Instead of the change you have, can you add something like: if (!info) return; if (info->dev) dev_set_drvdata(info->dev, NULL); to the top of cleanup_one_si() instead? I think that would be a cleaner and more general. -corey On 09/08/2014 07:19 PM,

[RESEND PATCH] ipmi: Clear drvdata when interface is removed by hotmod

Add another email of maintainer just in case. This patch fixes a bug on hotmod removing. After ipmi interface is removed using hotmod, kernel panic occurs when rmmod impi_si. For example, try this: # echo "remove,"`cat /proc/ipmi/0/params` > \ /sys/module/ipmi_si/parameters/hotmod # rmmod ip

[PATCH] ipmi: Clear drvdata when interface is removed by hotmod

This patch fixes a bug on hotmod removing. After ipmi interface is removed using hotmod, kernel panic occurs when rmmod impi_si. For example, try this: # echo "remove,"`cat /proc/ipmi/0/params` > \ /sys/module/ipmi_si/parameters/hotmod # rmmod ipmi_si Then, rmmod fails with the following mess