Re: [PATCH] ipv4/ipvs: Convert to kthread API

2007-04-22 Thread Christoph Hellwig
On Thu, Apr 19, 2007 at 03:59:44PM -0700, Andrew Morton wrote: > There still seems to be quite a lot of complexity in this driver's > thread handling which could be removed if we did a full conversion > to the kthread API. > > It all looks surprisingly complex in there. It is. There quite

Re: [PATCH] ipv4/ipvs: Convert to kthread API

2007-04-22 Thread Christoph Hellwig
On Thu, Apr 19, 2007 at 03:59:44PM -0700, Andrew Morton wrote: There still seems to be quite a lot of complexity in this driver's thread handling which could be removed if we did a full conversion to the kthread API. It all looks surprisingly complex in there. It is. There quite a few

Re: [PATCH] ipv4/ipvs: Convert to kthread API

2007-04-19 Thread Andrew Morton
On Thu, 19 Apr 2007 18:04:36 +0900 Simon Horman <[EMAIL PROTECTED]> wrote: > On Thu, Apr 19, 2007 at 01:58:57AM -0600, Eric W. Biederman wrote: > > From: Eric W. Biederman <[EMAIL PROTECTED]> > > > > Modify startup of ipvs sync threads to use kthread_run > > instead of a weird combination of

Re: [PATCH] ipv4/ipvs: Convert to kthread API

2007-04-19 Thread Simon Horman
On Thu, Apr 19, 2007 at 01:58:57AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> > > Modify startup of ipvs sync threads to use kthread_run > instead of a weird combination of calling kernel_thread > to start a fork_sync_thread whose hole purpose in life was > to

[PATCH] ipv4/ipvs: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> Modify startup of ipvs sync threads to use kthread_run instead of a weird combination of calling kernel_thread to start a fork_sync_thread whose hole purpose in life was to call kernel_thread again starting the actually sync thread which called

[PATCH] ipv4/ipvs: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted Modify startup of ipvs sync threads to use kthread_run instead of a weird combination of calling kernel_thread to start a fork_sync_thread whose hole purpose in life was to call kernel_thread again starting the actually sync thread which

[PATCH] ipv4/ipvs: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Modify startup of ipvs sync threads to use kthread_run instead of a weird combination of calling kernel_thread to start a fork_sync_thread whose hole purpose in life was to call kernel_thread again starting the actually sync thread which called

[PATCH] ipv4/ipvs: Convert to kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] Modify startup of ipvs sync threads to use kthread_run instead of a weird combination of calling kernel_thread to start a fork_sync_thread whose hole purpose in life was to call kernel_thread again starting the actually sync thread which called daemonize.

Re: [PATCH] ipv4/ipvs: Convert to kthread API

2007-04-19 Thread Simon Horman
On Thu, Apr 19, 2007 at 01:58:57AM -0600, Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] Modify startup of ipvs sync threads to use kthread_run instead of a weird combination of calling kernel_thread to start a fork_sync_thread whose hole purpose in life was to call

Re: [PATCH] ipv4/ipvs: Convert to kthread API

2007-04-19 Thread Andrew Morton
On Thu, 19 Apr 2007 18:04:36 +0900 Simon Horman [EMAIL PROTECTED] wrote: On Thu, Apr 19, 2007 at 01:58:57AM -0600, Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] Modify startup of ipvs sync threads to use kthread_run instead of a weird combination of calling