Re: [PATCH] ipv4: Fix runtime WARNING in rtmsg_ifa()

2014-02-06 Thread David Miller
From: Geert Uytterhoeven Date: Wed, 5 Feb 2014 08:38:25 +0100 > On m68k/ARAnyM: ... > Adding some debugging code reveals that net_fill_ifaddr() fails in > > put_cacheinfo(skb, ifa->ifa_cstamp, ifa->ifa_tstamp, > preferred, valid)) > > nla_put complains: > >

Re: [PATCH] ipv4: Fix runtime WARNING in rtmsg_ifa()

2014-02-05 Thread Cong Wang
On Tue, Feb 4, 2014 at 11:38 PM, Geert Uytterhoeven wrote: > Apparently commit 5c766d642bcaffd0c2a5b354db2068515b3846cf ("ipv4: > introduce address lifetime") forgot to take into account the addition of > struct ifa_cacheinfo in inet_nlmsg_size(). Hence add it, like is already > done for ipv6. > >

Re: [PATCH] ipv4: Fix runtime WARNING in rtmsg_ifa()

2014-02-05 Thread Geert Uytterhoeven
On Wed, Feb 5, 2014 at 6:30 PM, Cong Wang wrote: > On Tue, Feb 4, 2014 at 11:38 PM, Geert Uytterhoeven > wrote: >> Apparently commit 5c766d642bcaffd0c2a5b354db2068515b3846cf ("ipv4: >> introduce address lifetime") forgot to take into account the addition of >> struct ifa_cacheinfo in inet_nlmsg_s

[PATCH] ipv4: Fix runtime WARNING in rtmsg_ifa()

2014-02-04 Thread Geert Uytterhoeven
On m68k/ARAnyM: WARNING: CPU: 0 PID: 407 at net/ipv4/devinet.c:1599 0x316a99() Modules linked in: CPU: 0 PID: 407 Comm: ifconfig Not tainted 3.13.0-atari-09263-g0c71d68014d1 #1378 Stack from 10c4fdf0: 10c4fdf0 002ffabb 000243e8 008ced6c 00024416 00316a99 063f 00316a99