Re: [PATCH] ipvs: Keep skb->sk when allocating headroom on tunnel xmit

2014-11-11 Thread Simon Horman
On Sat, Nov 08, 2014 at 08:16:58AM +0200, Julian Anastasov wrote: > > Hello, > > On Fri, 7 Nov 2014, Calvin Owens wrote: > > > On 11/05/2014 01:21 AM, Julian Anastasov wrote: > > > > > > Hello, > > > > > > On Tue, 4 Nov 2014, Calvin Owens wrote: > > > > > > > ip_vs_prepare_tunneled_skb()

Re: [PATCH] ipvs: Keep skb->sk when allocating headroom on tunnel xmit

2014-11-07 Thread Julian Anastasov
Hello, On Fri, 7 Nov 2014, Calvin Owens wrote: > On 11/05/2014 01:21 AM, Julian Anastasov wrote: > > > > Hello, > > > > On Tue, 4 Nov 2014, Calvin Owens wrote: > > > > > ip_vs_prepare_tunneled_skb() ignores ->sk when allocating a new > > > skb, either unconditionally setting ->sk to NUL

Re: [PATCH] ipvs: Keep skb->sk when allocating headroom on tunnel xmit

2014-11-07 Thread Calvin Owens
On 11/05/2014 01:21 AM, Julian Anastasov wrote: Hello, On Tue, 4 Nov 2014, Calvin Owens wrote: ip_vs_prepare_tunneled_skb() ignores ->sk when allocating a new skb, either unconditionally setting ->sk to NULL or allowing the uninitialized ->sk from a newly allocated skb to leak through

Re: [PATCH] ipvs: Keep skb->sk when allocating headroom on tunnel xmit

2014-11-05 Thread Julian Anastasov
Hello, On Tue, 4 Nov 2014, Calvin Owens wrote: > ip_vs_prepare_tunneled_skb() ignores ->sk when allocating a new > skb, either unconditionally setting ->sk to NULL or allowing > the uninitialized ->sk from a newly allocated skb to leak through > to the caller. > > This patch properly co

[PATCH] ipvs: Keep skb->sk when allocating headroom on tunnel xmit

2014-11-04 Thread Calvin Owens
ip_vs_prepare_tunneled_skb() ignores ->sk when allocating a new skb, either unconditionally setting ->sk to NULL or allowing the uninitialized ->sk from a newly allocated skb to leak through to the caller. This patch properly copies ->sk and increments its reference count. Signed-off-by: Calvin O