Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-12-06 Thread Marcel Holtmann
Hi David, might it not make more sense to put all of that into a new subdirectory, say, /drivers/char/pcmcia/ipwireless_cs? that way, it's more modular and it will keep that higher-level directory from potentially getting cluttered with even more drivers. and it would let you drop the point

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-12-04 Thread David Sterba
Hi, > might it not make more sense to put all of that into a new > subdirectory, say, /drivers/char/pcmcia/ipwireless_cs? that way, it's > more modular and it will keep that higher-level directory from > potentially getting cluttered with even more drivers. and it would > let you drop the pointl

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-12-04 Thread David Sterba
Hi, > can we please drop the stupid "_cs" stuff. It is an old habit to have > the shortcut for "Card Services" in the driver name, but that goes back > to the time when the PCMCIA subsystem and its drivers were an external > package. Especially in cases where only a PCMCIA card exists, it makes >

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-12-01 Thread Marcel Holtmann
Hi David, > I'm submitting driver for IPWireless PC Card, used for 4G > internet connection. > The driver has been in -mm series as ipwireless_cs.git tree for > some time, is actively used and there are currently no > outstanding bugs. > > I'd like to let the driver pass through LKML and then let

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-11-30 Thread Michael Robb
>At the moment they seem to be ending up under serial, so I would prefer >consistency between the USB tty interfaces for 3G cards, the stuff like ?Nozomi and any newer goodies. That makes sense - I was wondering how the device drivers are going to be categorised given that the same hardware can be

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-11-30 Thread Alan Cox
On Fri, 30 Nov 2007 15:20:19 + (GMT) [EMAIL PROTECTED] (Michael Robb) wrote: > >If the -main- purpose of the hardware is wireless, it should go in via > >John Linville, wireless maintainer... > > These GPRS cards are basically wireless modems which accept a Hayes command > set (AT+, etc..

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-11-30 Thread Michael Robb
>If the -main- purpose of the hardware is wireless, it should go in via >John Linville, wireless maintainer... These GPRS cards are basically wireless modems which accept a Hayes command set (AT+, etc...), can send and receive SMS messages, as well as support WAP and PPP internet surfing. Ha

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-11-30 Thread Jiri Kosina
On Fri, 30 Nov 2007, Jeff Garzik wrote: > > Driver lives in drivers/char/pcmcia directory, it's a serial driver. > > I'm not sure if this is the right place, since it's a networking > > driver too and therefore should be in drivers/net/pcmcia. > If the -main- purpose of the hardware is wireless

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-11-30 Thread Jeff Garzik
David Sterba wrote: Hi, I'm submitting driver for IPWireless PC Card, used for 4G internet connection. The driver has been in -mm series as ipwireless_cs.git tree for some time, is actively used and there are currently no outstanding bugs. I'd like to let the driver pass through LKML and then l

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-11-30 Thread Jiri Slaby
On 11/30/2007 01:55 PM, David Sterba wrote: > Hi, > > I'm submitting driver for IPWireless PC Card, used for 4G > internet connection. > The driver has been in -mm series as ipwireless_cs.git tree for > some time, is actively used and there are currently no > outstanding bugs. Almost :). [...] >

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-11-30 Thread Robert P. J. Day
On Fri, 30 Nov 2007, David Sterba wrote: ... > drivers/char/pcmcia/Kconfig|8 > drivers/char/pcmcia/Makefile |4 > drivers/char/pcmcia/ipwireless_cs_hardware.c | 1728 > + > drivers/char/pcmcia/ipwireless_cs_hardware