Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-06-11 Thread Saidi, Ali
On 6/8/20, 8:49 AM, "Thomas Gleixner" wrote: "Herrenschmidt, Benjamin" writes: > On Wed, 2020-06-03 at 16:16 +0100, Marc Zyngier wrote: >> > My original patch should certain check activated and not disabled. >> > With that do you still have reservations Marc? >>

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-06-08 Thread Thomas Gleixner
Ben, Benjamin Herrenschmidt writes: > On Mon, 2020-06-08 at 15:48 +0200, Thomas Gleixner wrote: >> >if (cpu != its_dev->event_map.col_map[id]) { >> >target_col = _dev->its->collections[cpu]; >> > - its_send_movi(its_dev, target_col, id); >> > + >> > + /* If the

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-06-08 Thread Benjamin Herrenschmidt
On Mon, 2020-06-08 at 15:48 +0200, Thomas Gleixner wrote: > "Herrenschmidt, Benjamin" writes: > > On Wed, 2020-06-03 at 16:16 +0100, Marc Zyngier wrote: > > > > My original patch should certain check activated and not disabled. > > > > With that do you still have reservations Marc? > > > > > >

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-06-08 Thread Thomas Gleixner
"Herrenschmidt, Benjamin" writes: > On Wed, 2020-06-03 at 16:16 +0100, Marc Zyngier wrote: >> > My original patch should certain check activated and not disabled. >> > With that do you still have reservations Marc? >> >> I'd still prefer it if we could do something in core code, rather >> than

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-06-03 Thread Herrenschmidt, Benjamin
On Wed, 2020-06-03 at 16:16 +0100, Marc Zyngier wrote: > > My original patch should certain check activated and not disabled. > > With that do you still have reservations Marc? > > I'd still prefer it if we could do something in core code, rather > than spreading these checks in the individual

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-06-03 Thread Marc Zyngier
On 2020-06-02 19:47, Saidi, Ali wrote: [...] Looks like the x86 apic set_affinity call explicitly checks for if it’s activated in the managed case which makes sense given the code Ben posted above: /* * Core code can call here for inactive interrupts. For inactive

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-06-03 Thread Marc Zyngier
On 2020-06-02 21:54, Thomas Gleixner wrote: "Herrenschmidt, Benjamin" writes: On Sun, 2020-05-31 at 12:09 +0100, Marc Zyngier wrote: > The semantic of activate/deactivate (which maps to started/shutdown > in the IRQ code) is that the HW resources for a given interrupt are > only committed

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-06-02 Thread Thomas Gleixner
"Herrenschmidt, Benjamin" writes: > On Sun, 2020-05-31 at 12:09 +0100, Marc Zyngier wrote: >> > The semantic of activate/deactivate (which maps to started/shutdown >> > in the IRQ code) is that the HW resources for a given interrupt are >> > only committed when the interrupt is activated. Trying

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-06-02 Thread Saidi, Ali
On 5/31/20, 9:40 PM, "Herrenschmidt, Benjamin" wrote: On Sun, 2020-05-31 at 12:09 +0100, Marc Zyngier wrote: > > > > Not great indeed. But this is not, as far as I can tell, a GIC > > driver problem. > > > > The semantic of activate/deactivate (which maps to

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-31 Thread Herrenschmidt, Benjamin
On Sun, 2020-05-31 at 12:09 +0100, Marc Zyngier wrote: > > > > Not great indeed. But this is not, as far as I can tell, a GIC > > driver problem. > > > > The semantic of activate/deactivate (which maps to started/shutdown > > in the IRQ code) is that the HW resources for a given interrupt are >

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-31 Thread Saidi, Ali
Marc, > On May 31, 2020, at 6:10 AM, Marc Zyngier wrote: >> Not great indeed. But this is not, as far as I can tell, a GIC >> driver problem. >> >> The semantic of activate/deactivate (which maps to started/shutdown >> in the IRQ code) is that the HW resources for a given interrupt are >> only

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-31 Thread Marc Zyngier
On 2020-05-30 17:49, Marc Zyngier wrote: Hi Ali, On Fri, 29 May 2020 12:36:42 + "Saidi, Ali" wrote: Hi Marc, > On May 29, 2020, at 3:33 AM, Marc Zyngier wrote: > > Hi Ali, > >> On 2020-05-29 02:55, Ali Saidi wrote: >> If an interrupt is disabled the ITS driver has sent a discard

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-30 Thread kbuild test robot
Hi Ali, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on linux/master v5.7-rc7] [cannot apply to tip/irq/core arm-jcooper/irqchip/for-next next-20200529] [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-30 Thread Marc Zyngier
Hi Ali, On Fri, 29 May 2020 12:36:42 + "Saidi, Ali" wrote: > Hi Marc, > > > On May 29, 2020, at 3:33 AM, Marc Zyngier wrote: > > > > Hi Ali, > > > >> On 2020-05-29 02:55, Ali Saidi wrote: > >> If an interrupt is disabled the ITS driver has sent a discard removing > >> the DeviceID and

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-29 Thread Saidi, Ali
Hi Marc, > On May 29, 2020, at 3:33 AM, Marc Zyngier wrote: > > Hi Ali, > >> On 2020-05-29 02:55, Ali Saidi wrote: >> If an interrupt is disabled the ITS driver has sent a discard removing >> the DeviceID and EventID from the ITT. After this occurs it can't be >> moved to another collection

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-29 Thread Marc Zyngier
Hi Ali, On 2020-05-29 02:55, Ali Saidi wrote: If an interrupt is disabled the ITS driver has sent a discard removing the DeviceID and EventID from the ITT. After this occurs it can't be moved to another collection with a MOVI and a command error occurs if attempted. Before issuing the MOVI

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-28 Thread Zenghui Yu
Hi, On 2020/5/29 9:55, Ali Saidi wrote: If an interrupt is disabled the ITS driver has sent a discard removing the DeviceID and EventID from the ITT. After this occurs it can't be moved to another collection with a MOVI and a command error occurs if attempted. Before issuing the MOVI command

[PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-28 Thread Ali Saidi
If an interrupt is disabled the ITS driver has sent a discard removing the DeviceID and EventID from the ITT. After this occurs it can't be moved to another collection with a MOVI and a command error occurs if attempted. Before issuing the MOVI command make sure that the IRQ isn't disabled and