Re: [PATCH] irqchip: Silence sparse warning

2014-03-11 Thread Stephen Boyd
On 03/10/14 06:08, Jiri Kosina wrote: > On Tue, 4 Mar 2014, Stephen Boyd wrote: > >> drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init' >> was not declared. Should it be static? >> >> Signed-off-by: Stephen Boyd > Why do we have to have drivers/irqchip/irqchip.h and >

Re: [PATCH] irqchip: Silence sparse warning

2014-03-11 Thread Stephen Boyd
On 03/10/14 06:08, Jiri Kosina wrote: On Tue, 4 Mar 2014, Stephen Boyd wrote: drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init' was not declared. Should it be static? Signed-off-by: Stephen Boyd sb...@codeaurora.org Why do we have to have drivers/irqchip/irqchip.h and

Re: [PATCH] irqchip: Silence sparse warning

2014-03-10 Thread Jiri Kosina
On Tue, 4 Mar 2014, Stephen Boyd wrote: > drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init' > was not declared. Should it be static? > > Signed-off-by: Stephen Boyd Why do we have to have drivers/irqchip/irqchip.h and include/linux/irqchip.h anyway? > --- >

Re: [PATCH] irqchip: Silence sparse warning

2014-03-10 Thread Jiri Kosina
On Tue, 4 Mar 2014, Stephen Boyd wrote: drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init' was not declared. Should it be static? Signed-off-by: Stephen Boyd sb...@codeaurora.org Why do we have to have drivers/irqchip/irqchip.h and include/linux/irqchip.h anyway? ---

[PATCH] irqchip: Silence sparse warning

2014-03-04 Thread Stephen Boyd
drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init' was not declared. Should it be static? Signed-off-by: Stephen Boyd --- drivers/irqchip/irqchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c index

[PATCH] irqchip: Silence sparse warning

2014-03-04 Thread Stephen Boyd
drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init' was not declared. Should it be static? Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/irqchip/irqchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c index