On 2021-02-18 09:38, Greg KH wrote:
On Thu, Feb 18, 2021 at 09:04:42AM +, Marc Zyngier wrote:
On Thu, 18 Feb 2021 08:54:00 +,
Greg KH wrote:
[...]
> > > Wow, wait, you are removing a debugfs file _before_ debugfs is even
> > > initialized? Didn't expect that, ok, let me go try this a
On Thu, Feb 18, 2021 at 09:04:42AM +, Marc Zyngier wrote:
> On Thu, 18 Feb 2021 08:54:00 +,
> Greg KH wrote:
>
> [...]
>
> > > > Wow, wait, you are removing a debugfs file _before_ debugfs is even
> > > > initialized? Didn't expect that, ok, let me go try this again...
> > >
> > > Yeah
On Thu, 18 Feb 2021 08:52:53 +,
Greg KH wrote:
[...]
> Ok, how about this:
>
>
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 2fcf66473436..86c7f0489620 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -297,7 +297,7 @@ struct dentry *debugfs_lookup(const ch
Am 2021-02-18 09:52, schrieb Greg KH:
On Thu, Feb 18, 2021 at 09:27:09AM +0100, Michael Walle wrote:
Am 2021-02-18 08:31, schrieb Greg KH:
> On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote:
> > On Wed, 17 Feb 2021 20:10:50 +,
> > Michael Walle wrote:
> > >
> > > Am 2021-02-17 2
On Thu, 18 Feb 2021 08:54:00 +,
Greg KH wrote:
[...]
> > > Wow, wait, you are removing a debugfs file _before_ debugfs is even
> > > initialized? Didn't expect that, ok, let me go try this again...
> >
> > Yeah, that's a poor man's rename (file being deleted and re-created).
>
> True, but
On 2021-02-18 08:38, Greg KH wrote:
On Thu, Feb 18, 2021 at 09:27:09AM +0100, Michael Walle wrote:
Am 2021-02-18 08:31, schrieb Greg KH:
> On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote:
> > On Wed, 17 Feb 2021 20:10:50 +,
> > Michael Walle wrote:
> > >
> > > Am 2021-02-17 21:
On Wed, Feb 17, 2021 at 08:57:17PM +0100, Michael Walle wrote:
> Hi Greg,
>
> > There's no need to keep around a dentry pointer to a simple file that
> > debugfs itself can look up when we need to remove it from the system.
> > So simplify the code by deleting the variable and cleaning up the logi
On Thu, Feb 18, 2021 at 09:27:09AM +0100, Michael Walle wrote:
> Am 2021-02-18 08:31, schrieb Greg KH:
> > On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote:
> > > On Wed, 17 Feb 2021 20:10:50 +,
> > > Michael Walle wrote:
> > > >
> > > > Am 2021-02-17 21:02, schrieb Marc Zyngier:
>
On Thu, Feb 18, 2021 at 08:47:15AM +, Marc Zyngier wrote:
> On 2021-02-18 08:38, Greg KH wrote:
> > On Thu, Feb 18, 2021 at 09:27:09AM +0100, Michael Walle wrote:
> > > Am 2021-02-18 08:31, schrieb Greg KH:
> > > > On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote:
> > > > > On Wed,
On Thu, Feb 18, 2021 at 09:27:09AM +0100, Michael Walle wrote:
> Am 2021-02-18 08:31, schrieb Greg KH:
> > On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote:
> > > On Wed, 17 Feb 2021 20:10:50 +,
> > > Michael Walle wrote:
> > > >
> > > > Am 2021-02-17 21:02, schrieb Marc Zyngier:
>
Am 2021-02-18 09:40, schrieb Greg KH:
On Wed, Feb 17, 2021 at 08:57:17PM +0100, Michael Walle wrote:
Hi Greg,
> There's no need to keep around a dentry pointer to a simple file that
> debugfs itself can look up when we need to remove it from the system.
> So simplify the code by deleting the va
Am 2021-02-18 08:31, schrieb Greg KH:
On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote:
On Wed, 17 Feb 2021 20:10:50 +,
Michael Walle wrote:
>
> Am 2021-02-17 21:02, schrieb Marc Zyngier:
> > On 2021-02-17 19:57, Michael Walle wrote:
> >> Hi Greg,
> >>
> >>> There's no need to k
On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote:
> On Wed, 17 Feb 2021 20:10:50 +,
> Michael Walle wrote:
> >
> > Am 2021-02-17 21:02, schrieb Marc Zyngier:
> > > On 2021-02-17 19:57, Michael Walle wrote:
> > >> Hi Greg,
> > >>
> > >>> There's no need to keep around a dentry poi
On Wed, Feb 17, 2021 at 11:21:22PM +0100, Michael Walle wrote:
> Am 2021-02-17 22:50, schrieb Marc Zyngier:
> > On Wed, 17 Feb 2021 20:10:50 +,
> > Michael Walle wrote:
> > >
> > > Am 2021-02-17 21:02, schrieb Marc Zyngier:
> > > > On 2021-02-17 19:57, Michael Walle wrote:
> > > >> Hi Greg,
>
Am 2021-02-17 22:50, schrieb Marc Zyngier:
On Wed, 17 Feb 2021 20:10:50 +,
Michael Walle wrote:
Am 2021-02-17 21:02, schrieb Marc Zyngier:
> On 2021-02-17 19:57, Michael Walle wrote:
>> Hi Greg,
>>
>>> There's no need to keep around a dentry pointer to a simple file that
>>> debugfs itself
On Wed, 17 Feb 2021 20:10:50 +,
Michael Walle wrote:
>
> Am 2021-02-17 21:02, schrieb Marc Zyngier:
> > On 2021-02-17 19:57, Michael Walle wrote:
> >> Hi Greg,
> >>
> >>> There's no need to keep around a dentry pointer to a simple file that
> >>> debugfs itself can look up when we need to re
On 2021-02-17 19:57, Michael Walle wrote:
Hi Greg,
There's no need to keep around a dentry pointer to a simple file that
debugfs itself can look up when we need to remove it from the system.
So simplify the code by deleting the variable and cleaning up the
logic
around the debugfs file.
Thi
Hi Greg,
> There's no need to keep around a dentry pointer to a simple file that
> debugfs itself can look up when we need to remove it from the system.
> So simplify the code by deleting the variable and cleaning up the logic
> around the debugfs file.
This will generate the following oops on my
There's no need to keep around a dentry pointer to a simple file that
debugfs itself can look up when we need to remove it from the system.
So simplify the code by deleting the variable and cleaning up the logic
around the debugfs file.
Cc: Marc Zyngier
Cc: Thomas Gleixner
Cc: linux-kernel@vger.
19 matches
Mail list logo
