Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
On Thu, Oct 26, 2017 at 4:04 PM, Bart Van Assche wrote: > On Thu, 2017-10-26 at 10:24 +0200, Kees Cook wrote: >> On Wed, Oct 25, 2017 at 5:03 PM, Bart Van Assche >> wrote: >> > On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote: >> > > However, maintainers: sorry to send this one -- it can't be

Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-26 Thread Bart Van Assche
On Thu, 2017-10-26 at 10:24 +0200, Kees Cook wrote: > On Wed, Oct 25, 2017 at 5:03 PM, Bart Van Assche > wrote: > > On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote: > > > However, maintainers: sorry to send this one -- it can't be merged > > > yet, this uses timer_setup_on_stack() which is onl

Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
On Wed, Oct 25, 2017 at 5:03 PM, Bart Van Assche wrote: > On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote: >> However, maintainers: sorry to send this one -- it can't be merged >> yet, this uses timer_setup_on_stack() which is only in -next right >> now. If it looks okay, though, I can carry th

Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-25 Thread Bart Van Assche
On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote: > However, maintainers: sorry to send this one -- it can't be merged > yet, this uses timer_setup_on_stack() which is only in -next right > now. If it looks okay, though, I can carry this in the timer tree. Hello Kees, Can you have a look at the

Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
On Wed, Oct 25, 2017 at 2:41 PM, Jason A. Donenfeld wrote: > On Wed, Oct 25, 2017 at 12:01 PM, Kees Cook wrote: >> sess->time2retain_timer.expires = >> (get_jiffies_64() + sess->sess_ops->DefaultTime2Retain * HZ); >> add_timer(&sess->time2retain_timer); >>

Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-25 Thread Jason A. Donenfeld
On Wed, Oct 25, 2017 at 12:01 PM, Kees Cook wrote: > sess->time2retain_timer.expires = > (get_jiffies_64() + sess->sess_ops->DefaultTime2Retain * HZ); > add_timer(&sess->time2retain_timer); > cmd->dataout_timer.expires = (get_jiffies_64() + na->dataout_timeo

[PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Includes a fix for correcting an on-stack timer usage. Cc: "Nicholas A. Bellinger" Cc: Jiang Yi Cc: Varun