Re: [PATCH] isdn: use setup_timer

2017-03-24 Thread David Miller
From: Geliang Tang Date: Thu, 23 Mar 2017 21:15:57 +0800 > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang Applied, thanks. It would be really nice to get rid of all of the (void *) casts these

Re: [PATCH] isdn: use setup_timer

2017-03-24 Thread David Miller
From: Geliang Tang Date: Thu, 23 Mar 2017 21:15:57 +0800 > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang Applied, thanks. It would be really nice to get rid of all of the (void *) casts these calls do. In particular this turns off type

[PATCH] isdn: use setup_timer

2017-03-23 Thread Geliang Tang
Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang --- drivers/isdn/divert/isdn_divert.c | 9 +++-- drivers/isdn/hardware/eicon/divasi.c| 5 ++--- drivers/isdn/hardware/mISDN/hfcmulti.c | 10 --

[PATCH] isdn: use setup_timer

2017-03-23 Thread Geliang Tang
Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang --- drivers/isdn/divert/isdn_divert.c | 9 +++-- drivers/isdn/hardware/eicon/divasi.c| 5 ++--- drivers/isdn/hardware/mISDN/hfcmulti.c | 10 --

[PATCH] isdn: Use setup_timer and mod_timer

2015-02-27 Thread Vaishali Thakkar
Use timer API functions setup_timer and mod_timer instead of structure assignments as they are standard way to set the timer and to update the expire field of an active timer respectively. This is done using Coccinelle and semantic patch used for this is as follows: // @@ expression x,y,z,a,b;

[PATCH] isdn: Use setup_timer and mod_timer

2015-02-27 Thread Vaishali Thakkar
Use timer API functions setup_timer and mod_timer instead of structure assignments as they are standard way to set the timer and to update the expire field of an active timer respectively. This is done using Coccinelle and semantic patch used for this is as follows: // smpl @@ expression