Re: [PATCH] isofs: fix High Sierra dirent flag accesses

2020-06-22 Thread Egor Chelak
On 6/23/2020 12:22 AM, Matthew Wilcox wrote: > It's been about 22 years since I contributed the patch which added > support for the Acorn extensions ;-) But I'm pretty sure that it's not > possible to have an Acorn CD-ROM that is also an HSF CD-ROM. That is, > all Acorn formatted CD-ROMs are

Re: [PATCH] isofs: fix High Sierra dirent flag accesses

2020-06-22 Thread Matthew Wilcox
On Sun, Jun 21, 2020 at 07:08:17AM +0300, Egor Chelak wrote: > The flags byte of the dirent was accessed as de->flags[0] in a couple of > places, and not as de->flags[-sbi->s_high_sierra], which is how it's > accessed elsewhere. This caused a bug, where some files on an HSF disc > could be

Re: [PATCH] isofs: fix High Sierra dirent flag accesses

2020-06-22 Thread Matthew Wilcox
On Sun, Jun 21, 2020 at 07:08:17AM +0300, Egor Chelak wrote: > The flags byte of the dirent was accessed as de->flags[0] in a couple of > places, and not as de->flags[-sbi->s_high_sierra], which is how it's > accessed elsewhere. This caused a bug, where some files on an HSF disc > could be

[PATCH] isofs: fix High Sierra dirent flag accesses

2020-06-20 Thread Egor Chelak
The flags byte of the dirent was accessed as de->flags[0] in a couple of places, and not as de->flags[-sbi->s_high_sierra], which is how it's accessed elsewhere. This caused a bug, where some files on an HSF disc could be inaccessible. For context, here is the difference between HSF dirents and