Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-06-07 Thread Jason Gunthorpe
On Thu, Jun 07, 2018 at 01:10:39AM -0700, Greg Thelen wrote: > > > I don't really think I like this approach though. At a minimum if you > > > are going to make iWARP totally dependent on rdmacm, then there is zero > > > reason that iw_cm.o should be part of the obj-$(CONFIG_INFINIBAND) > > >

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-06-07 Thread Jason Gunthorpe
On Thu, Jun 07, 2018 at 01:10:39AM -0700, Greg Thelen wrote: > > > I don't really think I like this approach though. At a minimum if you > > > are going to make iWARP totally dependent on rdmacm, then there is zero > > > reason that iw_cm.o should be part of the obj-$(CONFIG_INFINIBAND) > > >

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-06-07 Thread Greg Thelen
On Mon, Jun 4, 2018 at 4:07 PM Jason Gunthorpe wrote: > > On Thu, May 31, 2018 at 02:40:59PM -0400, Doug Ledford wrote: > > On Wed, 2018-05-30 at 21:03 -0700, Greg Thelen wrote: > > > On Wed, May 30, 2018 at 4:01 PM Jason Gunthorpe wrote: > > > > > > > On Thu, May 31, 2018 at 12:40:54AM +0200,

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-06-07 Thread Greg Thelen
On Mon, Jun 4, 2018 at 4:07 PM Jason Gunthorpe wrote: > > On Thu, May 31, 2018 at 02:40:59PM -0400, Doug Ledford wrote: > > On Wed, 2018-05-30 at 21:03 -0700, Greg Thelen wrote: > > > On Wed, May 30, 2018 at 4:01 PM Jason Gunthorpe wrote: > > > > > > > On Thu, May 31, 2018 at 12:40:54AM +0200,

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-06-04 Thread Jason Gunthorpe
On Thu, May 31, 2018 at 02:40:59PM -0400, Doug Ledford wrote: > On Wed, 2018-05-30 at 21:03 -0700, Greg Thelen wrote: > > On Wed, May 30, 2018 at 4:01 PM Jason Gunthorpe wrote: > > > > > On Thu, May 31, 2018 at 12:40:54AM +0200, Arnd Bergmann wrote: > > > > > On 5/30/2018 5:25 PM, Jason

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-06-04 Thread Jason Gunthorpe
On Thu, May 31, 2018 at 02:40:59PM -0400, Doug Ledford wrote: > On Wed, 2018-05-30 at 21:03 -0700, Greg Thelen wrote: > > On Wed, May 30, 2018 at 4:01 PM Jason Gunthorpe wrote: > > > > > On Thu, May 31, 2018 at 12:40:54AM +0200, Arnd Bergmann wrote: > > > > > On 5/30/2018 5:25 PM, Jason

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-06-04 Thread Jason Gunthorpe
On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: > The newly added fill_res_ep_entry function fails to link if > CONFIG_INFINIBAND_ADDR_TRANS is not set: > > drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry': > restrack.c:(.text+0x3cc): undefined reference to

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-06-04 Thread Jason Gunthorpe
On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: > The newly added fill_res_ep_entry function fails to link if > CONFIG_INFINIBAND_ADDR_TRANS is not set: > > drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry': > restrack.c:(.text+0x3cc): undefined reference to

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-31 Thread Doug Ledford
On Wed, 2018-05-30 at 21:03 -0700, Greg Thelen wrote: > On Wed, May 30, 2018 at 4:01 PM Jason Gunthorpe wrote: > > > On Thu, May 31, 2018 at 12:40:54AM +0200, Arnd Bergmann wrote: > > > > On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: > > > > > On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-31 Thread Doug Ledford
On Wed, 2018-05-30 at 21:03 -0700, Greg Thelen wrote: > On Wed, May 30, 2018 at 4:01 PM Jason Gunthorpe wrote: > > > On Thu, May 31, 2018 at 12:40:54AM +0200, Arnd Bergmann wrote: > > > > On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: > > > > > On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Greg Thelen
On Wed, May 30, 2018 at 4:01 PM Jason Gunthorpe wrote: > On Thu, May 31, 2018 at 12:40:54AM +0200, Arnd Bergmann wrote: > > > On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: > > >> On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: > > >>> > > >>> On 5/30/2018 5:04 PM, Jason Gunthorpe

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Greg Thelen
On Wed, May 30, 2018 at 4:01 PM Jason Gunthorpe wrote: > On Thu, May 31, 2018 at 12:40:54AM +0200, Arnd Bergmann wrote: > > > On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: > > >> On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: > > >>> > > >>> On 5/30/2018 5:04 PM, Jason Gunthorpe

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Jason Gunthorpe
On Thu, May 31, 2018 at 12:40:54AM +0200, Arnd Bergmann wrote: > > On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: > >> On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: > >>> > >>> On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: > On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Jason Gunthorpe
On Thu, May 31, 2018 at 12:40:54AM +0200, Arnd Bergmann wrote: > > On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: > >> On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: > >>> > >>> On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: > On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Arnd Bergmann
On Thu, May 31, 2018 at 12:29 AM, Steve Wise wrote: > > > On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: >> On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: >>> >>> On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: > The

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Arnd Bergmann
On Thu, May 31, 2018 at 12:29 AM, Steve Wise wrote: > > > On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: >> On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: >>> >>> On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: > The

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Steve Wise
On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: > On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: >> >> On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: >>> On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: The newly added fill_res_ep_entry function fails to link if

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Steve Wise
On 5/30/2018 5:25 PM, Jason Gunthorpe wrote: > On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: >> >> On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: >>> On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: The newly added fill_res_ep_entry function fails to link if

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Jason Gunthorpe
On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: > > > On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: > > On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: > >> The newly added fill_res_ep_entry function fails to link if > >> CONFIG_INFINIBAND_ADDR_TRANS is not set: > >> >

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Jason Gunthorpe
On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote: > > > On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: > > On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: > >> The newly added fill_res_ep_entry function fails to link if > >> CONFIG_INFINIBAND_ADDR_TRANS is not set: > >> >

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Steve Wise
On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: > On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: >> The newly added fill_res_ep_entry function fails to link if >> CONFIG_INFINIBAND_ADDR_TRANS is not set: >> >> drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry':

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Steve Wise
On 5/30/2018 5:04 PM, Jason Gunthorpe wrote: > On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: >> The newly added fill_res_ep_entry function fails to link if >> CONFIG_INFINIBAND_ADDR_TRANS is not set: >> >> drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry':

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Jason Gunthorpe
On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: > The newly added fill_res_ep_entry function fails to link if > CONFIG_INFINIBAND_ADDR_TRANS is not set: > > drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry': > restrack.c:(.text+0x3cc): undefined reference to

Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Jason Gunthorpe
On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote: > The newly added fill_res_ep_entry function fails to link if > CONFIG_INFINIBAND_ADDR_TRANS is not set: > > drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry': > restrack.c:(.text+0x3cc): undefined reference to

[PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Arnd Bergmann
The newly added fill_res_ep_entry function fails to link if CONFIG_INFINIBAND_ADDR_TRANS is not set: drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry': restrack.c:(.text+0x3cc): undefined reference to `rdma_res_to_id' restrack.c:(.text+0x3d0): undefined reference to

[PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

2018-05-30 Thread Arnd Bergmann
The newly added fill_res_ep_entry function fails to link if CONFIG_INFINIBAND_ADDR_TRANS is not set: drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry': restrack.c:(.text+0x3cc): undefined reference to `rdma_res_to_id' restrack.c:(.text+0x3d0): undefined reference to