Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-23 Thread Kalle Valo
Jiri Kosina wrote: > From: Jiri Kosina > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs > disabled (e.g. from LED core). We can't enable BHs in such a situation. > > Turn the unconditional BH-enable/BH-disable code into > hardirq-disable/conditional-enable. > >

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-23 Thread Jiri Kosina
On Tue, 23 Mar 2021, Sedat Dilek wrote: > > > > > > > > Johannes is telling me that he merged this patch internally, > > > > > > > > but I have no > > > > > > > > idea what is happening to it ... ? > > > > > > > > > > > > > > > > The reported splat is a clear bug, so it should be fixed one > >

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-23 Thread Sedat Dilek
On Mon, Mar 22, 2021 at 1:13 PM Jiri Kosina wrote: > > On Sat, 13 Mar 2021, Luca Coelho wrote: > > > > > > > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with > > > > > > > > > hard IRQs > > > > > > > > > disabled (e.g. from LED core). We can't enable BHs in such a > > > > > > >

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-22 Thread Jiri Kosina
On Sat, 13 Mar 2021, Luca Coelho wrote: > > > > > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with > > > > > > > > hard IRQs > > > > > > > > disabled (e.g. from LED core). We can't enable BHs in such a > > > > > > > > situation. > > > > > > > > > > > > > > > > Turn the

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-13 Thread Luca Coelho
On Sat, 2021-03-13 at 19:06 +0200, Kalle Valo wrote: > Luca Coelho writes: > > > On Sat, 2021-03-13 at 16:43 +0100, Jiri Kosina wrote: > > > On Sat, 13 Mar 2021, Kalle Valo wrote: > > > > > > > > > > From: Jiri Kosina > > > > > > > > > > > > > > It's possible for iwl_pcie_enqueue_hcmd() to be

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-13 Thread Kalle Valo
Luca Coelho writes: > On Sat, 2021-03-13 at 16:43 +0100, Jiri Kosina wrote: >> On Sat, 13 Mar 2021, Kalle Valo wrote: >> >> > > > > From: Jiri Kosina >> > > > > >> > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard >> > > > > IRQs >> > > > > disabled (e.g. from LED

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-13 Thread Luca Coelho
On Sat, 2021-03-13 at 16:43 +0100, Jiri Kosina wrote: > On Sat, 13 Mar 2021, Kalle Valo wrote: > > > > > > From: Jiri Kosina > > > > > > > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs > > > > > disabled (e.g. from LED core). We can't enable BHs in such a > > > >

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-13 Thread Jiri Kosina
On Sat, 13 Mar 2021, Kalle Valo wrote: > >> > From: Jiri Kosina > >> > > >> > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs > >> > disabled (e.g. from LED core). We can't enable BHs in such a situation. > >> > > >> > Turn the unconditional BH-enable/BH-disable code

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-12 Thread Sedat Dilek
On Sat, Mar 13, 2021 at 6:45 AM Kalle Valo wrote: > > Jiri Kosina writes: > > > On Mon, 8 Mar 2021, Jiri Kosina wrote: > > > >> > From: Jiri Kosina > >> > > >> > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs > >> > disabled (e.g. from LED core). We can't enable BHs in

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-12 Thread Kalle Valo
Jiri Kosina writes: > On Mon, 8 Mar 2021, Jiri Kosina wrote: > >> > From: Jiri Kosina >> > >> > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs >> > disabled (e.g. from LED core). We can't enable BHs in such a situation. >> > >> > Turn the unconditional

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-12 Thread Jiri Kosina
On Mon, 8 Mar 2021, Jiri Kosina wrote: > > From: Jiri Kosina > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs > > disabled (e.g. from LED core). We can't enable BHs in such a situation. > > > > Turn the unconditional BH-enable/BH-disable code into > >

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-08 Thread Jiri Kosina
On Tue, 2 Mar 2021, Jiri Kosina wrote: > From: Jiri Kosina > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs > disabled (e.g. from LED core). We can't enable BHs in such a situation. > > Turn the unconditional BH-enable/BH-disable code into >

[PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-02 Thread Jiri Kosina
From: Jiri Kosina It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs disabled (e.g. from LED core). We can't enable BHs in such a situation. Turn the unconditional BH-enable/BH-disable code into hardirq-disable/conditional-enable. This fixes the warning below. WARNING: