Re: [PATCH] ix86: improve determination of X86_MINIMUM_CPU_FAMILY

2012-09-07 Thread H. Peter Anvin
On 09/07/2012 12:31 AM, Jan Beulich wrote: Further, the "6" case is then completely pointless - X86_P6_NOP depends on X86_64. And with all features the kernel cares about that got added with Pentium and later being CPUID-enumerable, the "5" case would then be superfluous too. The dependency X

Re: [PATCH] ix86: improve determination of X86_MINIMUM_CPU_FAMILY

2012-09-07 Thread Jan Beulich
>>> On 07.09.12 at 09:31, Jan Beulich wrote: On 07.09.12 at 09:16, "H. Peter Anvin" wrote: > > Erk, this isn't right either. We're not supposed to include > > CPUID-enumerable features here, so X86_CMOV, X86_CMPXCHG64 and X86_TSC > > don't belong, and should instead be done via required-fe

Re: [PATCH] ix86: improve determination of X86_MINIMUM_CPU_FAMILY

2012-09-07 Thread Jan Beulich
>>> On 07.09.12 at 09:16, "H. Peter Anvin" wrote: > On 09/06/2012 11:48 PM, Jan Beulich wrote: >> >> --- 3.6-rc4/arch/x86/Kconfig.cpu >> +++ 3.6-rc4-x86-minimum-cpu-family/arch/x86/Kconfig.cpu >> @@ -409,9 +409,9 @@ config X86_CMOV >> config X86_MINIMUM_CPU_FAMILY >> int >> default "64

Re: [PATCH] ix86: improve determination of X86_MINIMUM_CPU_FAMILY

2012-09-07 Thread H. Peter Anvin
On 09/06/2012 11:48 PM, Jan Beulich wrote: --- 3.6-rc4/arch/x86/Kconfig.cpu +++ 3.6-rc4-x86-minimum-cpu-family/arch/x86/Kconfig.cpu @@ -409,9 +409,9 @@ config X86_CMOV config X86_MINIMUM_CPU_FAMILY int default "64" if X86_64 - default "6" if X86_32 && X86_P6_NOP - d

[PATCH] ix86: improve determination of X86_MINIMUM_CPU_FAMILY

2012-09-06 Thread Jan Beulich
This was quite a bit off: While I never build for anything older than i686 (other than for specifically trying certain things out), one of my 32-bit configs (tailor made for a VIA system) ended up having this set to 4. Others, customized for more mainstream systems, had this set to 5. Once at it,