Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-02-06 Thread Mingming Cao
On Tue, 2008-02-05 at 13:59 -0500, Josef Bacik wrote: > On Tuesday 05 February 2008 12:27:31 pm Jan Kara wrote: > > Hello, > > > > Sorry for replying a bit late but I'm currently falling behind in > > maling-list reading... > > > > > The way jbd tries to determine if there is enough space left

Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-02-06 Thread Jan Kara
On Tue 05-02-08 13:59:05, Josef Bacik wrote: > On Tuesday 05 February 2008 12:27:31 pm Jan Kara wrote: > > Hello, > > > > Sorry for replying a bit late but I'm currently falling behind in > > maling-list reading... > > > > > The way jbd tries to determine if there is enough space left on the >

Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-02-05 Thread Josef Bacik
On Tuesday 05 February 2008 12:27:31 pm Jan Kara wrote: > Hello, > > Sorry for replying a bit late but I'm currently falling behind in > maling-list reading... > > > The way jbd tries to determine if there is enough space left on the > > journal in order to start a new transaction is looking at

Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-02-05 Thread Jan Kara
Hello, Sorry for replying a bit late but I'm currently falling behind in maling-list reading... > The way jbd tries to determine if there is enough space left on the journal in > order to start a new transaction is looking at the space left in the journal > and > the space needed for the com

Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-01-31 Thread Mingming Cao
On Thu, 2008-01-31 at 16:52 -0500, Josef Bacik wrote: > On Thu, Jan 31, 2008 at 12:35:43PM -0700, Andreas Dilger wrote: > > On Jan 31, 2008 11:14 -0500, Josef Bacik wrote: > > [snip excellent analysis] > > > So you get into this situation where > > > t_nr_buffers (the actual number of buffers that

Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-01-31 Thread Josef Bacik
On Thu, Jan 31, 2008 at 12:35:43PM -0700, Andreas Dilger wrote: > On Jan 31, 2008 11:14 -0500, Josef Bacik wrote: > [snip excellent analysis] > > So you get into this situation where > > t_nr_buffers (the actual number of buffers that are on the transaction) is > > greater than the number of buffe

Re: [PATCH] jbd: fix assertion failure in journal_next_log_block

2008-01-31 Thread Andreas Dilger
On Jan 31, 2008 11:14 -0500, Josef Bacik wrote: [snip excellent analysis] > So you get into this situation where > t_nr_buffers (the actual number of buffers that are on the transaction) is > greater than the number of buffers accounted for via t_outstanding_credits. > This presents a problem sinc

[PATCH] jbd: fix assertion failure in journal_next_log_block

2008-01-31 Thread Josef Bacik
Hello, The way jbd tries to determine if there is enough space left on the journal in order to start a new transaction is looking at the space left in the journal and the space needed for the committing transaction, which is 1/4 of the journal + the number of t_outstanding_credits for that transac