Re: [PATCH] jffs2: fix invocations of dbg_xattr() for dead jffs2_xattr_ref

2018-12-15 Thread Hou Tao
On 2018/12/14 5:53, Richard Weinberger wrote: > On Sun, Dec 9, 2018 at 7:52 AM Boris Brezillon > wrote: >> >> On Sat, 20 Oct 2018 19:07:53 +0800 >> Hou Tao wrote: >> >>> When jffs2_xattr_ref is dead, xref->ic or xref->xd will be invalid >>> because these fields will be reused as xref->ino or x

Re: [PATCH] jffs2: fix invocations of dbg_xattr() for dead jffs2_xattr_ref

2018-12-13 Thread Richard Weinberger
On Sun, Dec 9, 2018 at 7:52 AM Boris Brezillon wrote: > > On Sat, 20 Oct 2018 19:07:53 +0800 > Hou Tao wrote: > > > When jffs2_xattr_ref is dead, xref->ic or xref->xd will be invalid > > because these fields will be reused as xref->ino or xref->xid, > > so access xref->ic->ino or xref->xd->xid wi

Re: [PATCH] jffs2: fix invocations of dbg_xattr() for dead jffs2_xattr_ref

2018-12-08 Thread Boris Brezillon
On Sat, 20 Oct 2018 19:07:53 +0800 Hou Tao wrote: > When jffs2_xattr_ref is dead, xref->ic or xref->xd will be invalid > because these fields will be reused as xref->ino or xref->xid, > so access xref->ic->ino or xref->xd->xid will lead to Oops. > > Fix the problem by checking whether or not it

Re: [PATCH] jffs2: fix invocations of dbg_xattr() for dead jffs2_xattr_ref

2018-12-08 Thread Hou Tao
ping ? On 2018/10/20 19:07, Hou Tao wrote: > When jffs2_xattr_ref is dead, xref->ic or xref->xd will be invalid > because these fields will be reused as xref->ino or xref->xid, > so access xref->ic->ino or xref->xd->xid will lead to Oops. > > Fix the problem by checking whether or not it is a dea

[PATCH] jffs2: fix invocations of dbg_xattr() for dead jffs2_xattr_ref

2018-10-20 Thread Hou Tao
When jffs2_xattr_ref is dead, xref->ic or xref->xd will be invalid because these fields will be reused as xref->ino or xref->xid, so access xref->ic->ino or xref->xd->xid will lead to Oops. Fix the problem by checking whether or not it is a dead xref. Signed-off-by: Hou Tao --- fs/jffs2/xattr.c