Re: [PATCH] jffs2: remove fd from the f->dents list immediately.

2018-03-19 Thread yuyufen
Hi, David On 2018/3/16 20:52, David Woodhouse wrote: On Fri, 2018-03-16 at 12:39 +, Joakim Tjernlund wrote: After reverting the commit, we test 'rm -r', which can remove all files, and all seems OK! UHH, this is mine (and Davids work from 2007)! I cannot remember any details this long aft

Re: [PATCH] jffs2: remove fd from the f->dents list immediately.

2018-03-16 Thread David Woodhouse
On Fri, 2018-03-16 at 12:39 +, Joakim Tjernlund wrote: > > > After reverting the commit, we test 'rm -r', which can remove all > > files, and all seems OK! > > UHH, this is mine (and Davids work from 2007)! > I cannot remember  any details this long afterwards but I guess you cannot > just >

Re: [PATCH] jffs2: remove fd from the f->dents list immediately.

2018-03-16 Thread Joakim Tjernlund
On Fri, 2018-03-16 at 19:05 +0800, Yufen Yu wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > commit 15953580e79b ("[JFFS2] Improve getdents vs. f_pos handling

[PATCH] jffs2: remove fd from the f->dents list immediately.

2018-03-16 Thread Yufen Yu
commit 15953580e79b ("[JFFS2] Improve getdents vs. f_pos handling on NOR flash.") is introduced to resolve 'rm -r', which cannot remove all files: http://lists.infradead.org/pipermail/linux-mtd/2007-October/019658.html However, it can cause the following issues: 1. 'deletion' dirents is alwa