Re: [PATCH] jprobes: Ensure that the probepoint is at function entry

2017-07-07 Thread Naveen N. Rao
On 2017/07/07 12:49PM, Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > On Thu, 6 Jul 2017 14:15:49 +0200 > > Ingo Molnar wrote: > > > > > * Masami Hiramatsu wrote: > > > > > > > > Also, 'function_offset_within_entry' is way too long a name, and it's > > > > > also a > > > > > minome

Re: [PATCH] jprobes: Ensure that the probepoint is at function entry

2017-07-07 Thread Ingo Molnar
* Masami Hiramatsu wrote: > On Thu, 6 Jul 2017 14:15:49 +0200 > Ingo Molnar wrote: > > > * Masami Hiramatsu wrote: > > > > > > Also, 'function_offset_within_entry' is way too long a name, and it's > > > > also a > > > > minomer I think. The purpose of this function is to enforce that the

Re: [PATCH] jprobes: Ensure that the probepoint is at function entry

2017-07-06 Thread Masami Hiramatsu
On Thu, 6 Jul 2017 14:15:49 +0200 Ingo Molnar wrote: > * Masami Hiramatsu wrote: > > > > Also, 'function_offset_within_entry' is way too long a name, and it's > > > also a > > > minomer I think. The purpose of this function is to enforce that the > > > relative > > > 'offset' of a new probe

Re: [PATCH] jprobes: Ensure that the probepoint is at function entry

2017-07-06 Thread Ingo Molnar
* Masami Hiramatsu wrote: > > Also, 'function_offset_within_entry' is way too long a name, and it's also > > a > > minomer I think. The purpose of this function is to enforce that the > > relative > > 'offset' of a new probe is at the standard function entry offset: i.e. 0 on > > most > > a

Re: [PATCH] jprobes: Ensure that the probepoint is at function entry

2017-07-06 Thread Masami Hiramatsu
On Wed, 5 Jul 2017 12:42:16 +0200 Ingo Molnar wrote: > > * Naveen N. Rao wrote: > > > Similar to commit 90ec5e89e393c ("kretprobes: Ensure probe location is > > at function entry"), ensure that the jprobe probepoint is at function > > entry. Sorry I missed it. > > > > Signed-off-by: Naveen

Re: [PATCH] jprobes: Ensure that the probepoint is at function entry

2017-07-05 Thread Ingo Molnar
* Naveen N. Rao wrote: > Similar to commit 90ec5e89e393c ("kretprobes: Ensure probe location is > at function entry"), ensure that the jprobe probepoint is at function > entry. > > Signed-off-by: Naveen N. Rao > --- > kernel/kprobes.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deleti

[PATCH] jprobes: Ensure that the probepoint is at function entry

2017-06-29 Thread Naveen N. Rao
Similar to commit 90ec5e89e393c ("kretprobes: Ensure probe location is at function entry"), ensure that the jprobe probepoint is at function entry. Signed-off-by: Naveen N. Rao --- kernel/kprobes.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/kprobes.c b/ke