Re: [PATCH] jump_label: unlikely(x) > 0

2013-10-16 Thread Ingo Molnar
* H. Peter Anvin wrote: > On 10/11/2013 01:57 PM, Andrew Morton wrote: > > > > I'm sure this was intended instead ;) The patch doesn't seem to make > > any difference in code generation with my gcc. > > > > Which is odd, because doesn't unlikely() booleanize? It's supposed to:

Re: [PATCH] jump_label: unlikely(x) 0

2013-10-16 Thread Ingo Molnar
* H. Peter Anvin h...@linux.intel.com wrote: On 10/11/2013 01:57 PM, Andrew Morton wrote: I'm sure this was intended instead ;) The patch doesn't seem to make any difference in code generation with my gcc. Which is odd, because doesn't unlikely() booleanize? It's supposed to:

Re: [PATCH] jump_label: unlikely(x) > 0

2013-10-15 Thread H. Peter Anvin
On 10/11/2013 01:57 PM, Andrew Morton wrote: > > I'm sure this was intended instead ;) The patch doesn't seem to make > any difference in code generation with my gcc. > Which is odd, because doesn't unlikely() booleanize? -hpa -- To unsubscribe from this list: send the line

Re: [PATCH] jump_label: unlikely(x) 0

2013-10-15 Thread H. Peter Anvin
On 10/11/2013 01:57 PM, Andrew Morton wrote: I'm sure this was intended instead ;) The patch doesn't seem to make any difference in code generation with my gcc. Which is odd, because doesn't unlikely() booleanize? -hpa -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] jump_label: unlikely(x) > 0

2013-10-11 Thread Andrew Morton
On Fri, 11 Oct 2013 22:50:50 +0200 (CEST) Roel Kluin wrote: > untested, but wasn't this intended instead? > -- > if (unlikely(x) > 0) doesn't seem to help branch prediction > > ... > > --- a/include/linux/jump_label.h > +++ b/include/linux/jump_label.h > @@ -132,14 +132,14 @@

[PATCH] jump_label: unlikely(x) > 0

2013-10-11 Thread Roel Kluin
untested, but wasn't this intended instead? -- if (unlikely(x) > 0) doesn't seem to help branch prediction Signed-off-by: Roel Kluin --- diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h index a507907..cf08540 100644 --- a/include/linux/jump_label.h +++

[PATCH] jump_label: unlikely(x) 0

2013-10-11 Thread Roel Kluin
untested, but wasn't this intended instead? -- if (unlikely(x) 0) doesn't seem to help branch prediction Signed-off-by: Roel Kluin roel.kl...@gmail.com --- diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h index a507907..cf08540 100644 ---

Re: [PATCH] jump_label: unlikely(x) 0

2013-10-11 Thread Andrew Morton
On Fri, 11 Oct 2013 22:50:50 +0200 (CEST) Roel Kluin roel.kl...@gmail.com wrote: untested, but wasn't this intended instead? -- if (unlikely(x) 0) doesn't seem to help branch prediction ... --- a/include/linux/jump_label.h +++ b/include/linux/jump_label.h @@ -132,14