Re: [PATCH] kbuild: Enable -Wsometimes-uninitialized

2019-05-22 Thread Nathan Chancellor
On Tue, Apr 30, 2019 at 11:46:44AM +0200, Arnd Bergmann wrote: > Ah, I thought they were all fixed, as I don't see any remaining warnings > in my tree. It seems that I never send this workaround for > DECLARE_WAIT_QUEUE_HEAD_ONSTACK: > > diff --git a/include/linux/wait.h b/include/linux/wait.h >

Re: [PATCH] kbuild: Enable -Wsometimes-uninitialized

2019-05-01 Thread Masahiro Yamada
On Wed, May 1, 2019 at 5:54 AM Nathan Chancellor wrote: > > On Tue, Apr 30, 2019 at 11:46:44AM +0200, Arnd Bergmann wrote: > > On Tue, Apr 30, 2019 at 11:33 AM Nathan Chancellor > > wrote: > > > On Tue, Apr 30, 2019 at 09:16:50AM +0200, Arnd Bergmann wrote: > > > > On Tue, Apr 30, 2019 at 3:01

Re: [PATCH] kbuild: Enable -Wsometimes-uninitialized

2019-04-30 Thread Nathan Chancellor
On Tue, Apr 30, 2019 at 11:46:44AM +0200, Arnd Bergmann wrote: > On Tue, Apr 30, 2019 at 11:33 AM Nathan Chancellor > wrote: > > On Tue, Apr 30, 2019 at 09:16:50AM +0200, Arnd Bergmann wrote: > > > On Tue, Apr 30, 2019 at 3:01 AM Nathan Chancellor > > > wrote: > > > > > > > > This is Clang's

Re: [PATCH] kbuild: Enable -Wsometimes-uninitialized

2019-04-30 Thread Arnd Bergmann
On Tue, Apr 30, 2019 at 11:33 AM Nathan Chancellor wrote: > On Tue, Apr 30, 2019 at 09:16:50AM +0200, Arnd Bergmann wrote: > > On Tue, Apr 30, 2019 at 3:01 AM Nathan Chancellor > > wrote: > > > > > > This is Clang's version of GCC's -Wmaybe-uninitialized. Up to this > > > point, it has not been

Re: [PATCH] kbuild: Enable -Wsometimes-uninitialized

2019-04-30 Thread Nathan Chancellor
On Tue, Apr 30, 2019 at 09:16:50AM +0200, Arnd Bergmann wrote: > On Tue, Apr 30, 2019 at 3:01 AM Nathan Chancellor > wrote: > > > > This is Clang's version of GCC's -Wmaybe-uninitialized. Up to this > > point, it has not been used because -Wuninitialized has been disabled, > > which also turns

Re: [PATCH] kbuild: Enable -Wsometimes-uninitialized

2019-04-30 Thread Arnd Bergmann
On Tue, Apr 30, 2019 at 3:01 AM Nathan Chancellor wrote: > > This is Clang's version of GCC's -Wmaybe-uninitialized. Up to this > point, it has not been used because -Wuninitialized has been disabled, > which also turns off -Wsometimes-uninitialized, meaning that we miss out > on finding some

[PATCH] kbuild: Enable -Wsometimes-uninitialized

2019-04-29 Thread Nathan Chancellor
This is Clang's version of GCC's -Wmaybe-uninitialized. Up to this point, it has not been used because -Wuninitialized has been disabled, which also turns off -Wsometimes-uninitialized, meaning that we miss out on finding some bugs [1]. In my experience, it appears to be more accurate than GCC and