Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-16 Thread Masahiro Yamada
On Fri, Oct 12, 2018 at 12:33 AM Borislav Petkov wrote: > > On Fri, Oct 12, 2018 at 12:08:07AM +0900, Masahiro Yamada wrote: > > Install lz4c, and run 'make' again. > > Almost all objects have been built there, > > so you will finish it soon. > > So when this LZ4 thing got added at the time, the

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-16 Thread Masahiro Yamada
On Fri, Oct 12, 2018 at 12:33 AM Borislav Petkov wrote: > > On Fri, Oct 12, 2018 at 12:08:07AM +0900, Masahiro Yamada wrote: > > Install lz4c, and run 'make' again. > > Almost all objects have been built there, > > so you will finish it soon. > > So when this LZ4 thing got added at the time, the

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-11 Thread kbuild test robot
Hi Borislav, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc7 next-20181011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-11 Thread kbuild test robot
Hi Borislav, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc7 next-20181011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-11 Thread Borislav Petkov
On Fri, Oct 12, 2018 at 12:08:07AM +0900, Masahiro Yamada wrote: > Install lz4c, and run 'make' again. > Almost all objects have been built there, > so you will finish it soon. So when this LZ4 thing got added at the time, the lz4 package had to be downloaded and built and installed and it wasn't

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-11 Thread Borislav Petkov
On Fri, Oct 12, 2018 at 12:08:07AM +0900, Masahiro Yamada wrote: > Install lz4c, and run 'make' again. > Almost all objects have been built there, > so you will finish it soon. So when this LZ4 thing got added at the time, the lz4 package had to be downloaded and built and installed and it wasn't

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-11 Thread Masahiro Yamada
On Thu, Oct 11, 2018 at 5:54 PM Borislav Petkov wrote: > > On Thu, Oct 11, 2018 at 01:26:23PM +0900, Masahiro Yamada wrote: > > So, the cause of the failure is clear enough > > from the build log. > > Sure but it wasts unnecessary build cycles and appears only after all > the compilation units

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-11 Thread Masahiro Yamada
On Thu, Oct 11, 2018 at 5:54 PM Borislav Petkov wrote: > > On Thu, Oct 11, 2018 at 01:26:23PM +0900, Masahiro Yamada wrote: > > So, the cause of the failure is clear enough > > from the build log. > > Sure but it wasts unnecessary build cycles and appears only after all > the compilation units

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-11 Thread Borislav Petkov
On Thu, Oct 11, 2018 at 01:26:23PM +0900, Masahiro Yamada wrote: > So, the cause of the failure is clear enough > from the build log. Sure but it wasts unnecessary build cycles and appears only after all the compilation units have been produced. > It is weird to check only lz4c. > If

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-11 Thread Borislav Petkov
On Thu, Oct 11, 2018 at 01:26:23PM +0900, Masahiro Yamada wrote: > So, the cause of the failure is clear enough > from the build log. Sure but it wasts unnecessary build cycles and appears only after all the compilation units have been produced. > It is weird to check only lz4c. > If

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-10 Thread Masahiro Yamada
Hi Borislav, On Thu, Oct 11, 2018 at 7:23 AM Borislav Petkov wrote: > > From: Borislav Petkov > > When building randconfigs, the build fails at kernel compression stage > due to missing lz4 on the system but CONFIG_KERNEL_LZ4 has been selected > by randconfig. The result looks somethins like

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-10 Thread Masahiro Yamada
Hi Borislav, On Thu, Oct 11, 2018 at 7:23 AM Borislav Petkov wrote: > > From: Borislav Petkov > > When building randconfigs, the build fails at kernel compression stage > due to missing lz4 on the system but CONFIG_KERNEL_LZ4 has been selected > by randconfig. The result looks somethins like

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-10 Thread Randy Dunlap
On 10/10/18 3:23 PM, Borislav Petkov wrote: > From: Borislav Petkov > > When building randconfigs, the build fails at kernel compression stage > due to missing lz4 on the system but CONFIG_KERNEL_LZ4 has been selected > by randconfig. The result looks somethins like this: > > (cat

Re: [PATCH] kbuild: Fail the build early when no lz4 present

2018-10-10 Thread Randy Dunlap
On 10/10/18 3:23 PM, Borislav Petkov wrote: > From: Borislav Petkov > > When building randconfigs, the build fails at kernel compression stage > due to missing lz4 on the system but CONFIG_KERNEL_LZ4 has been selected > by randconfig. The result looks somethins like this: > > (cat

[PATCH] kbuild: Fail the build early when no lz4 present

2018-10-10 Thread Borislav Petkov
From: Borislav Petkov When building randconfigs, the build fails at kernel compression stage due to missing lz4 on the system but CONFIG_KERNEL_LZ4 has been selected by randconfig. The result looks somethins like this: (cat arch/x86/boot/compressed/vmlinux.bin

[PATCH] kbuild: Fail the build early when no lz4 present

2018-10-10 Thread Borislav Petkov
From: Borislav Petkov When building randconfigs, the build fails at kernel compression stage due to missing lz4 on the system but CONFIG_KERNEL_LZ4 has been selected by randconfig. The result looks somethins like this: (cat arch/x86/boot/compressed/vmlinux.bin