Re: [PATCH] kbuild: compile-test global headers to ensure they are self-contained

Hi Sam, On Tue, Jun 25, 2019 at 3:11 PM Sam Ravnborg wrote: > > > > > When all header files below include/drm are self-contained it will be a > > single line: > > > > header-test-y += $(all_headers_with_subdir) > In reality it will likely be the above, and then a list of > > header-test-n +=

Re: [PATCH] kbuild: compile-test global headers to ensure they are self-contained

> > When all header files below include/drm are self-contained it will be a > single line: > > header-test-y += $(all_headers_with_subdir) In reality it will likely be the above, and then a list of header-test-n += foo.h For the header files that we for one or the other reason do not want

Re: [PATCH] kbuild: compile-test global headers to ensure they are self-contained

Hi Masahiro > > ... > On this level it would be better to do: > header-test-y += $(call find_all_header_files) > > # drm files that are not self-contained > header-test-n += drm_legacy.h I made a quick hack on top of your patch to demonstrate the ideas. See patch below. When all header files bel

Re: [PATCH] kbuild: compile-test global headers to ensure they are self-contained

Hi Masahiro > At first, I tried to split Makefile per directory, > and add header-test-y one by one. > > I think you expect they look like this: > > > include/Makefile: > > subdir-y += drm > subdir-y += linux > subdir-y += media So far we agree. > include/drm/Makefile: > > header-test-y +=

Re: [PATCH] kbuild: compile-test global headers to ensure they are self-contained

Hi Sam, On Sat, Jun 22, 2019 at 2:51 AM Sam Ravnborg wrote: > > Hi Masahiro. > > On Sat, Jun 22, 2019 at 01:39:31AM +0900, Masahiro Yamada wrote: > > Make as many headers self-contained as possible so that they can be > > included without relying on a specific include order. > It is very nice fin

Re: [PATCH] kbuild: compile-test global headers to ensure they are self-contained

Hi Masahiro. On Sat, Jun 22, 2019 at 01:39:31AM +0900, Masahiro Yamada wrote: > Make as many headers self-contained as possible so that they can be > included without relying on a specific include order. It is very nice finally to get some infrastructure to validate header files. But to avoid too

[PATCH] kbuild: compile-test global headers to ensure they are self-contained

Make as many headers self-contained as possible so that they can be included without relying on a specific include order. This commit compiles only a few headers, but it is a good start point. Signed-off-by: Masahiro Yamada --- Makefile | 1 + include/Makefile | 31 +++