Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-24 Thread Arnd Bergmann
On Thursday, October 20, 2016 3:08:14 PM CEST Nicholas Piggin wrote: > On Wed, 19 Oct 2016 16:32:00 +0100 Russell King - ARM Linux > wrote: > > I'm not in favour of this. > > > >+extern void mmioset(void *, unsigned int, size_t); > >+extern void mmiocpy(void *,

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-24 Thread Arnd Bergmann
On Thursday, October 20, 2016 3:08:14 PM CEST Nicholas Piggin wrote: > On Wed, 19 Oct 2016 16:32:00 +0100 Russell King - ARM Linux > wrote: > > I'm not in favour of this. > > > >+extern void mmioset(void *, unsigned int, size_t); > >+extern void mmiocpy(void *, const void *, size_t); >

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-22 Thread Michal Marek
On Thu, Oct 20, 2016 at 03:33:27PM +0100, Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > > Good catch, I'm surprised you're the first one who reported it. This patch > > seems to do the trick for me: > > And me, thanks, so... > > > > > From:

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-22 Thread Michal Marek
On Thu, Oct 20, 2016 at 03:33:27PM +0100, Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > > Good catch, I'm surprised you're the first one who reported it. This patch > > seems to do the trick for me: > > And me, thanks, so... > > > > > From:

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Nicholas Piggin
On Thu, 20 Oct 2016 15:33:27 +0100 Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > > Good catch, I'm surprised you're the first one who reported it. This patch > > seems to do the trick for me: > > And me, thanks,

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Nicholas Piggin
On Thu, 20 Oct 2016 15:33:27 +0100 Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > > Good catch, I'm surprised you're the first one who reported it. This patch > > seems to do the trick for me: > > And me, thanks, so... > > > > > From:

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Russell King - ARM Linux
On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > Good catch, I'm surprised you're the first one who reported it. This patch > seems to do the trick for me: And me, thanks, so... > > From: Nicholas Piggin > Date: Fri, 21 Oct 2016 01:13:33 +1100 > Subject:

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Russell King - ARM Linux
On Fri, Oct 21, 2016 at 01:20:17AM +1100, Nicholas Piggin wrote: > Good catch, I'm surprised you're the first one who reported it. This patch > seems to do the trick for me: And me, thanks, so... > > From: Nicholas Piggin > Date: Fri, 21 Oct 2016 01:13:33 +1100 > Subject: [PATCH] kbuild:

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Nicholas Piggin
On Thu, 20 Oct 2016 14:17:02 +0100 Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 03:08:14PM +1100, Nicholas Piggin wrote: > > Fair point, what about leaving those as they are, and also adding > > them to asm-prototypes.h protected with GENKSYMS ifdef? It's not

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Nicholas Piggin
On Thu, 20 Oct 2016 14:17:02 +0100 Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 03:08:14PM +1100, Nicholas Piggin wrote: > > Fair point, what about leaving those as they are, and also adding > > them to asm-prototypes.h protected with GENKSYMS ifdef? It's not > > beautiful, but

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Russell King - ARM Linux
On Thu, Oct 20, 2016 at 03:08:14PM +1100, Nicholas Piggin wrote: > Fair point, what about leaving those as they are, and also adding > them to asm-prototypes.h protected with GENKSYMS ifdef? It's not > beautiful, but still better than armksyms.c before Al's patches (or > at least no worse). I

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Russell King - ARM Linux
On Thu, Oct 20, 2016 at 03:08:14PM +1100, Nicholas Piggin wrote: > Fair point, what about leaving those as they are, and also adding > them to asm-prototypes.h protected with GENKSYMS ifdef? It's not > beautiful, but still better than armksyms.c before Al's patches (or > at least no worse). I

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Geert Uytterhoeven
Hi Russell, On Thu, Oct 20, 2016 at 10:20 AM, Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 09:37:30AM +0200, Geert Uytterhoeven wrote: >> On Wed, Oct 19, 2016 at 5:32 PM, Russell King - ARM Linux >> wrote: >> > I'm not in favour of

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Geert Uytterhoeven
Hi Russell, On Thu, Oct 20, 2016 at 10:20 AM, Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 09:37:30AM +0200, Geert Uytterhoeven wrote: >> On Wed, Oct 19, 2016 at 5:32 PM, Russell King - ARM Linux >> wrote: >> > I'm not in favour of this. >> > >> >+extern void mmioset(void *,

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Russell King - ARM Linux
On Thu, Oct 20, 2016 at 09:37:30AM +0200, Geert Uytterhoeven wrote: > On Wed, Oct 19, 2016 at 5:32 PM, Russell King - ARM Linux > wrote: > > I'm not in favour of this. > > > >+extern void mmioset(void *, unsigned int, size_t); > >+extern void mmiocpy(void *, const

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Russell King - ARM Linux
On Thu, Oct 20, 2016 at 09:37:30AM +0200, Geert Uytterhoeven wrote: > On Wed, Oct 19, 2016 at 5:32 PM, Russell King - ARM Linux > wrote: > > I'm not in favour of this. > > > >+extern void mmioset(void *, unsigned int, size_t); > >+extern void mmiocpy(void *, const void *, size_t); > >

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Geert Uytterhoeven
On Wed, Oct 19, 2016 at 5:32 PM, Russell King - ARM Linux wrote: > I'm not in favour of this. > >+extern void mmioset(void *, unsigned int, size_t); >+extern void mmiocpy(void *, const void *, size_t); >+ > #ifndef __ARMBE__ > static inline void

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-20 Thread Geert Uytterhoeven
On Wed, Oct 19, 2016 at 5:32 PM, Russell King - ARM Linux wrote: > I'm not in favour of this. > >+extern void mmioset(void *, unsigned int, size_t); >+extern void mmiocpy(void *, const void *, size_t); >+ > #ifndef __ARMBE__ > static inline void memset_io(volatile void __iomem

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Nicholas Piggin
On Wed, 19 Oct 2016 16:32:00 +0100 Russell King - ARM Linux wrote: > On Wed, Oct 19, 2016 at 05:02:55PM +0200, Arnd Bergmann wrote: > > On Wednesday, October 19, 2016 4:52:06 PM CEST Michal Marek wrote: > > > Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > > > > This

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Nicholas Piggin
On Wed, 19 Oct 2016 16:32:00 +0100 Russell King - ARM Linux wrote: > On Wed, Oct 19, 2016 at 05:02:55PM +0200, Arnd Bergmann wrote: > > On Wednesday, October 19, 2016 4:52:06 PM CEST Michal Marek wrote: > > > Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > > > > This adds an

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Russell King - ARM Linux
On Wed, Oct 19, 2016 at 05:02:55PM +0200, Arnd Bergmann wrote: > On Wednesday, October 19, 2016 4:52:06 PM CEST Michal Marek wrote: > > Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > > > This adds an asm/asm-prototypes.h header for ARM to fix the > > > broken symbol versioning for symbols

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Russell King - ARM Linux
On Wed, Oct 19, 2016 at 05:02:55PM +0200, Arnd Bergmann wrote: > On Wednesday, October 19, 2016 4:52:06 PM CEST Michal Marek wrote: > > Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > > > This adds an asm/asm-prototypes.h header for ARM to fix the > > > broken symbol versioning for symbols

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Arnd Bergmann
On Wednesday, October 19, 2016 4:52:06 PM CEST Michal Marek wrote: > Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > > This adds an asm/asm-prototypes.h header for ARM to fix the > > broken symbol versioning for symbols exported from assembler > > files. > > > > In addition to the header, we

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Arnd Bergmann
On Wednesday, October 19, 2016 4:52:06 PM CEST Michal Marek wrote: > Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > > This adds an asm/asm-prototypes.h header for ARM to fix the > > broken symbol versioning for symbols exported from assembler > > files. > > > > In addition to the header, we

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Michal Marek
Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > This adds an asm/asm-prototypes.h header for ARM to fix the > broken symbol versioning for symbols exported from assembler > files. > > In addition to the header, we have to do these other small > changes: > > - move the 'extern' declarations out

Re: [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-19 Thread Michal Marek
Dne 17.10.2016 v 14:26 Arnd Bergmann napsal(a): > This adds an asm/asm-prototypes.h header for ARM to fix the > broken symbol versioning for symbols exported from assembler > files. > > In addition to the header, we have to do these other small > changes: > > - move the 'extern' declarations out

[PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-17 Thread Arnd Bergmann
This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol versioning for symbols exported from assembler files. In addition to the header, we have to do these other small changes: - move the 'extern' declarations out of memset_io/memcpy_io to make them visible to the symbol

[PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM

2016-10-17 Thread Arnd Bergmann
This adds an asm/asm-prototypes.h header for ARM to fix the broken symbol versioning for symbols exported from assembler files. In addition to the header, we have to do these other small changes: - move the 'extern' declarations out of memset_io/memcpy_io to make them visible to the symbol