Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Cyrill Gorcunov
On Sat, Jul 14, 2018 at 02:39:24PM -0500, Eric W. Biederman wrote: > Josh Triplett writes: > > > On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: > >> For a config option that no one has come forward with an actual real > >> world use case for disabling, that cost seems much

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Cyrill Gorcunov
On Sat, Jul 14, 2018 at 02:39:24PM -0500, Eric W. Biederman wrote: > Josh Triplett writes: > > > On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: > >> For a config option that no one has come forward with an actual real > >> world use case for disabling, that cost seems much

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Josh Triplett
On Sat, Jul 14, 2018 at 02:39:24PM -0500, Eric W. Biederman wrote: > Josh Triplett writes: > > > On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: > >> For a config option that no one has come forward with an actual real > >> world use case for disabling, that cost seems much

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Josh Triplett
On Sat, Jul 14, 2018 at 02:39:24PM -0500, Eric W. Biederman wrote: > Josh Triplett writes: > > > On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: > >> For a config option that no one has come forward with an actual real > >> world use case for disabling, that cost seems much

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Josh Triplett
On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: > For a config option that no one has come forward with an actual real > world use case for disabling, that cost seems much too high. The real-world use case is precisely as stated: code size, both storage and RAM. I regularly

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Josh Triplett
On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: > For a config option that no one has come forward with an actual real > world use case for disabling, that cost seems much too high. The real-world use case is precisely as stated: code size, both storage and RAM. I regularly

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Eric W. Biederman
Josh Triplett writes: > On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: >> For a config option that no one has come forward with an actual real >> world use case for disabling, that cost seems much too high. > > The real-world use case is precisely as stated: code size, both

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Eric W. Biederman
Josh Triplett writes: > On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: >> For a config option that no one has come forward with an actual real >> world use case for disabling, that cost seems much too high. > > The real-world use case is precisely as stated: code size, both

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Eric W. Biederman
Kees Cook writes: > On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton > wrote: >> On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) >> wrote: >>> What is the value of disabling this functionality ever? >>> >>> Is there any reason why we don't just delete

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Eric W. Biederman
Kees Cook writes: > On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton > wrote: >> On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) >> wrote: >>> What is the value of disabling this functionality ever? >>> >>> Is there any reason why we don't just delete

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Josh Triplett
On Fri, Jul 13, 2018 at 09:44:15PM -0700, Kees Cook wrote: > On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton > wrote: > > On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. > > Biederman) wrote: > >> What is the value of disabling this functionality ever? > >> > >> Is there any

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Josh Triplett
On Fri, Jul 13, 2018 at 09:44:15PM -0700, Kees Cook wrote: > On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton > wrote: > > On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. > > Biederman) wrote: > >> What is the value of disabling this functionality ever? > >> > >> Is there any

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Kees Cook
On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton wrote: > On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) > wrote: >> What is the value of disabling this functionality ever? >> >> Is there any reason why we don't just delete CONFIG_CHECKPOINT_RESTORE >> entirely? > >

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Kees Cook
On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton wrote: > On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) > wrote: >> What is the value of disabling this functionality ever? >> >> Is there any reason why we don't just delete CONFIG_CHECKPOINT_RESTORE >> entirely? > >

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Andrew Morton
On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) wrote: > > Adrian Reber writes: > > > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > > distribution kernels and also

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Andrew Morton
On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) wrote: > > Adrian Reber writes: > > > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > > distribution kernels and also

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Adrian Reber
On Fri, Jul 13, 2018 at 08:46:25AM -0500, Eric W. Biederman wrote: > Pavel Emelyanov writes: > > > On 07/12/2018 07:33 PM, Eric W. Biederman wrote: > >> > >> Adrian Reber writes: > >> > >>> The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > >>> combined with EXPERT.

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Adrian Reber
On Fri, Jul 13, 2018 at 08:46:25AM -0500, Eric W. Biederman wrote: > Pavel Emelyanov writes: > > > On 07/12/2018 07:33 PM, Eric W. Biederman wrote: > >> > >> Adrian Reber writes: > >> > >>> The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > >>> combined with EXPERT.

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Eric W. Biederman
Pavel Emelyanov writes: > On 07/12/2018 07:33 PM, Eric W. Biederman wrote: >> >> Adrian Reber writes: >> >>> The CHECKPOINT_RESTORE configuration option was introduced in 2012 and >>> combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many >>> distribution kernels and also part of

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Eric W. Biederman
Pavel Emelyanov writes: > On 07/12/2018 07:33 PM, Eric W. Biederman wrote: >> >> Adrian Reber writes: >> >>> The CHECKPOINT_RESTORE configuration option was introduced in 2012 and >>> combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many >>> distribution kernels and also part of

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Pavel Emelyanov
On 07/12/2018 07:33 PM, Eric W. Biederman wrote: > > Adrian Reber writes: > >> The CHECKPOINT_RESTORE configuration option was introduced in 2012 and >> combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many >> distribution kernels and also part of the defconfigs of various >>

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Pavel Emelyanov
On 07/12/2018 07:33 PM, Eric W. Biederman wrote: > > Adrian Reber writes: > >> The CHECKPOINT_RESTORE configuration option was introduced in 2012 and >> combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many >> distribution kernels and also part of the defconfigs of various >>

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Pavel Emelyanov
On 07/12/2018 04:07 PM, Adrian Reber wrote: > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > distribution kernels and also part of the defconfigs of various > architectures. > > To make it easier for

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Pavel Emelyanov
On 07/12/2018 04:07 PM, Adrian Reber wrote: > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > distribution kernels and also part of the defconfigs of various > architectures. > > To make it easier for

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Eric W. Biederman
Adrian Reber writes: > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > distribution kernels and also part of the defconfigs of various > architectures. > > To make it easier for distributions to

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Eric W. Biederman
Adrian Reber writes: > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > distribution kernels and also part of the defconfigs of various > architectures. > > To make it easier for distributions to

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Alice Frosi
On 12.07.2018 15:47, Hendrik Brueckner wrote: On Thu, Jul 12, 2018 at 03:07:33PM +0200, Adrian Reber wrote: The CHECKPOINT_RESTORE configuration option was introduced in 2012 and combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many distribution kernels and also part of the

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Alice Frosi
On 12.07.2018 15:47, Hendrik Brueckner wrote: On Thu, Jul 12, 2018 at 03:07:33PM +0200, Adrian Reber wrote: The CHECKPOINT_RESTORE configuration option was introduced in 2012 and combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many distribution kernels and also part of the

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Hendrik Brueckner
On Thu, Jul 12, 2018 at 03:07:33PM +0200, Adrian Reber wrote: > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > distribution kernels and also part of the defconfigs of various > architectures. > > To

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Hendrik Brueckner
On Thu, Jul 12, 2018 at 03:07:33PM +0200, Adrian Reber wrote: > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > distribution kernels and also part of the defconfigs of various > architectures. > > To

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Oleg Nesterov
On 07/12, Adrian Reber wrote: > > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > distribution kernels and also part of the defconfigs of various > architectures. > > To make it easier for distributions

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Oleg Nesterov
On 07/12, Adrian Reber wrote: > > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > distribution kernels and also part of the defconfigs of various > architectures. > > To make it easier for distributions

[PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Adrian Reber
The CHECKPOINT_RESTORE configuration option was introduced in 2012 and combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many distribution kernels and also part of the defconfigs of various architectures. To make it easier for distributions to enable CHECKPOINT_RESTORE this removes

[PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-12 Thread Adrian Reber
The CHECKPOINT_RESTORE configuration option was introduced in 2012 and combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many distribution kernels and also part of the defconfigs of various architectures. To make it easier for distributions to enable CHECKPOINT_RESTORE this removes