Hi Douglas,
On 2020/5/14 7:41, Doug Anderson wrote:
>> - }
>> + } else if (strcmp(argv[1], "KDBFLAGS") == 0)
>> + return KDB_NOPERM;
>
> One slight nit is that my personal preference is that if one half of
> an "if/else" needs braces then both halves should have braces.
Hi,
On Sun, May 10, 2020 at 7:18 PM Wei Li wrote:
>
> 'KDBFLAGS' is an internal variable of kdb, it is combined by 'KDBDEBUG'
> and state flags. But the user can define an environment variable named
> 'KDBFLAGS' too, so let's make it undefinable to avoid confusion.
>
> Signed-off-by: Wei Li
> --
'KDBFLAGS' is an internal variable of kdb, it is combined by 'KDBDEBUG'
and state flags. But the user can define an environment variable named
'KDBFLAGS' too, so let's make it undefinable to avoid confusion.
Signed-off-by: Wei Li
---
kernel/debug/kdb/kdb_main.c | 3 ++-
1 file changed, 2 inserti
3 matches
Mail list logo
