Re: [PATCH] kern/sys: Compat sysinfo syscall fix undefined behavior

2014-09-04 Thread Scotty Bauer
On 09/04/2014 02:14 PM, Andrew Morton wrote: > If I'm reading it correctly, this is all dead code because si_meminfo() > unconditionally sets sysinfo.mem_unit to PAGE_SIZE. It could all do with a > bit of a cleanup, I suspect. I'll do a little more research on this and do further clean up, if r

Re: [PATCH] kern/sys: Compat sysinfo syscall fix undefined behavior

2014-09-04 Thread Andrew Morton
On Thu, 04 Sep 2014 12:46:53 -0600 Scotty Bauer wrote: > Fix undefined behavior and compiler warning by replacing right > shift 32 with upper_32_bits macro > > Signed-off-by: Scotty Bauer > --- > kernel/sys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sys.

[PATCH] kern/sys: Compat sysinfo syscall fix undefined behavior

2014-09-04 Thread Scotty Bauer
Fix undefined behavior and compiler warning by replacing right shift 32 with upper_32_bits macro Signed-off-by: Scotty Bauer --- kernel/sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sys.c b/kernel/sys.c index ce81291..c78530b 100644 --- a/kernel/sys.c +++ b/ke