Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()

2013-10-26 Thread Chen Gang F T
On 10/26/2013 10:42 AM, Chen Gang wrote: > On 10/24/2013 11:29 PM, Josh Boyer wrote: >> On Wed, Oct 23, 2013 at 10:31 PM, Chen Gang wrote: >>> For some architectures, tool chain is not smart enough to recognize the >>> macro with multiple lines (e.g. arc tool chain), and for common ".S" >>> file,

Re: Portable assmbler code - newline (was Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL())

2013-10-26 Thread Chen Gang
On 10/25/2013 01:10 PM, Vineet Gupta wrote: > On 10/25/2013 01:11 AM, Geert Uytterhoeven wrote: >> On Thu, Oct 24, 2013 at 7:28 PM, Vineet Gupta wrote: +CC linux-arch On 10/24/2013 11:33 AM, Richard Weinberger wrote: >> On Thu, Oct 24, 2013 at 7:31 AM, Chen Gang wrote:

Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()

2013-10-25 Thread Chen Gang
On 10/24/2013 11:29 PM, Josh Boyer wrote: > On Wed, Oct 23, 2013 at 10:31 PM, Chen Gang wrote: >> For some architectures, tool chain is not smart enough to recognize the >> macro with multiple lines (e.g. arc tool chain), and for common ".S" >> file, this kind of macro is also rarely used. >> >> S

Re: Portable assmbler code - newline (was Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL())

2013-10-24 Thread Vineet Gupta
On 10/25/2013 01:11 AM, Geert Uytterhoeven wrote: > On Thu, Oct 24, 2013 at 7:28 PM, Vineet Gupta wrote: >> > +CC linux-arch >> > >> > On 10/24/2013 11:33 AM, Richard Weinberger wrote: >>> >> On Thu, Oct 24, 2013 at 7:31 AM, Chen Gang wrote: > >>> > For some architectures, tool chain is not s

Re: Portable assmbler code - newline (was Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL())

2013-10-24 Thread Geert Uytterhoeven
On Thu, Oct 24, 2013 at 7:28 PM, Vineet Gupta wrote: > +CC linux-arch > > On 10/24/2013 11:33 AM, Richard Weinberger wrote: >> On Thu, Oct 24, 2013 at 7:31 AM, Chen Gang wrote: >>> > For some architectures, tool chain is not smart enough to recognize the >>> > macro with multiple lines (e.g. arc

Portable assmbler code - newline (was Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL())

2013-10-24 Thread Vineet Gupta
+CC linux-arch On 10/24/2013 11:33 AM, Richard Weinberger wrote: > On Thu, Oct 24, 2013 at 7:31 AM, Chen Gang wrote: >> > For some architectures, tool chain is not smart enough to recognize the >> > macro with multiple lines (e.g. arc tool chain), and for common ".S" >> > file, this kind of macro

Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()

2013-10-24 Thread Josh Boyer
On Wed, Oct 23, 2013 at 10:31 PM, Chen Gang wrote: > For some architectures, tool chain is not smart enough to recognize the > macro with multiple lines (e.g. arc tool chain), and for common ".S" > file, this kind of macro is also rarely used. > > So expand the related contents of macro to let it

Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()

2013-10-24 Thread Chen Gang
On 10/24/2013 02:44 PM, Richard Weinberger wrote: > Am 24.10.2013 08:26, schrieb Chen Gang: >> On 10/24/2013 02:03 PM, Richard Weinberger wrote: >> Anyway, maybe it is also the tool chain's bug (so I include related arc >> tool chain guys in this mail). > > That's exactly my point. Before you blin

Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()

2013-10-23 Thread Richard Weinberger
Am 24.10.2013 08:26, schrieb Chen Gang: > On 10/24/2013 02:03 PM, Richard Weinberger wrote: > Anyway, maybe it is also the tool chain's bug (so I include related arc > tool chain guys in this mail). That's exactly my point. Before you blindly patch the kernel just to make it somehow build you need

Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()

2013-10-23 Thread Chen Gang
On 10/24/2013 02:03 PM, Richard Weinberger wrote: > On Thu, Oct 24, 2013 at 7:31 AM, Chen Gang wrote: >> For some architectures, tool chain is not smart enough to recognize the >> macro with multiple lines (e.g. arc tool chain), and for common ".S" >> file, this kind of macro is also rarely used.

Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()

2013-10-23 Thread Richard Weinberger
On Thu, Oct 24, 2013 at 7:31 AM, Chen Gang wrote: > For some architectures, tool chain is not smart enough to recognize the > macro with multiple lines (e.g. arc tool chain), and for common ".S" > file, this kind of macro is also rarely used. Does not "not smart enough" mean than the said toolcha

[PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()

2013-10-23 Thread Chen Gang
For some architectures, tool chain is not smart enough to recognize the macro with multiple lines (e.g. arc tool chain), and for common ".S" file, this kind of macro is also rarely used. So expand the related contents of macro to let it pass compiling (can use "arc-elf32-objdump -x" to know about