Re: [PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin

2008-01-22 Thread Rusty Russell
On Wednesday 23 January 2008 10:13:37 Jan Engelhardt wrote: > On Jan 21 2008 22:16, Rusty Russell wrote: > >On Monday 21 January 2008 20:08:25 Denis Cheng wrote: > >> the original code use KOBJ_NAME_LEN for built-in module name length, > >> that's defined to 20 in linux/kobject.h, but this is not e

Re: [PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin

2008-01-22 Thread rae l
On Jan 23, 2008 7:13 AM, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > But nf..dada_compat.c gets linked into nf_conntrack_ipv4.ko, > and that is what is used in /sys/module - and it fits the 20. > Any place where nf_conntrack_l3proto_ipv4_compat would still be used? there is a module named nf_conntr

Re: [PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin

2008-01-22 Thread Jan Engelhardt
On Jan 21 2008 22:16, Rusty Russell wrote: >On Monday 21 January 2008 20:08:25 Denis Cheng wrote: >> the original code use KOBJ_NAME_LEN for built-in module name length, >> that's defined to 20 in linux/kobject.h, but this is not enough appearntly, >> many module names are longer than this; >> #d

Re: [PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin

2008-01-21 Thread Rusty Russell
On Monday 21 January 2008 20:08:25 Denis Cheng wrote: > the original code use KOBJ_NAME_LEN for built-in module name length, > that's defined to 20 in linux/kobject.h, but this is not enough appearntly, > many module names are longer than this; > #define KOBJ_NAME_LEN 20 Thanks,

[PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin

2008-01-21 Thread Denis Cheng
the original code use KOBJ_NAME_LEN for built-in module name length, that's defined to 20 in linux/kobject.h, but this is not enough, some module names(such as nf_conntrack_proto_icmp) are longer than this; #define KOBJ_NAME_LEN 20 another macro is MODULE_NAME_LEN defined in lin

[PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin

2008-01-21 Thread Denis Cheng
the original code use KOBJ_NAME_LEN for built-in module name length, that's defined to 20 in linux/kobject.h, but this is not enough appearntly, many module names are longer than this; #define KOBJ_NAME_LEN 20 another macro is MODULE_NAME_LEN defined in linux/module.h, I think t

[PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin

2008-01-18 Thread rae l
From: Denis Cheng <[EMAIL PROTECTED]> Date: Sat, 19 Jan 2008 13:29:51 +0800 Subject: [PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin the original code use KOBJ_NAME_LEN for built-in module name length, that's defined to 20 in linux/kobject.h, but this is