Re: [PATCH] kernel/printk/printk.c: check_syslog_permissions() cleanup

2015-05-24 Thread Vasily Averin
On 15.05.2015 01:01, Andrew Morton wrote: > On Sun, 10 May 2015 09:35:53 +0300 Vasily Averin wrote: >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c >> @@ -484,11 +484,11 @@ int check_syslog_permissions(int type, bool from_file) >> * already done the capabilities checks at ope

Re: [PATCH] kernel/printk/printk.c: check_syslog_permissions() cleanup

2015-05-15 Thread Vasily Averin
On 15.05.2015 10:41, Vasily Averin wrote: > On 15.05.2015 01:01, Andrew Morton wrote: >> On Sun, 10 May 2015 09:35:53 +0300 Vasily Averin wrote: >> >>> Fixes: 637241a900cb ("kmsg: honor dmesg_restrict sysctl on /dev/kmsg") >>> >>> Final version of patch 637241a900cb ("kmsg: honor dmesg_restrict

Re: [PATCH] kernel/printk/printk.c: check_syslog_permissions() cleanup

2015-05-15 Thread Vasily Averin
On 15.05.2015 01:01, Andrew Morton wrote: > On Sun, 10 May 2015 09:35:53 +0300 Vasily Averin wrote: > >> Fixes: 637241a900cb ("kmsg: honor dmesg_restrict sysctl on /dev/kmsg") >> >> Final version of patch 637241a900cb ("kmsg: honor dmesg_restrict sysctl >> on /dev/kmsg") lost few hooks. As result

Re: [PATCH] kernel/printk/printk.c: check_syslog_permissions() cleanup

2015-05-14 Thread Andrew Morton
On Sun, 10 May 2015 09:35:53 +0300 Vasily Averin wrote: > Fixes: 637241a900cb ("kmsg: honor dmesg_restrict sysctl on /dev/kmsg") > > Final version of patch 637241a900cb ("kmsg: honor dmesg_restrict sysctl > on /dev/kmsg") lost few hooks. As result security_syslog() is not checked > inside check_

[PATCH] kernel/printk/printk.c: check_syslog_permissions() cleanup

2015-05-09 Thread Vasily Averin
Fixes: 637241a900cb ("kmsg: honor dmesg_restrict sysctl on /dev/kmsg") Final version of patch 637241a900cb ("kmsg: honor dmesg_restrict sysctl on /dev/kmsg") lost few hooks. As result security_syslog() is not checked inside check_syslog_permissions() if dmesg_restrict is set, or it can be called t