Re: [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning

On Thu, 2014-09-25 at 06:00 +0100, Al Viro wrote: > It's not you, it's checkpatch.pl plus the fairly common tendency to give > that thing a lot more respect than it deserves... > > Basically, it's OK as a tool that draws ones attention to a subset of > code that might or might not be worth looking

Re: [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning

On Thu, Sep 25, 2014 at 12:34:11AM -0400, Elshad Mustafayev wrote: > I am sorry if I disturbed you. I just follow the steps in kernel newbies to > get me in kernel development. It's not you, it's checkpatch.pl plus the fairly common tendency to give that thing a lot more respect than it deserves..

Re: [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning

On Wed, Sep 24, 2014 at 11:13:45PM -0400, Elshad Mustafayev wrote: > > Fixed a coding style issue. [] > > diff --git a/kernel/acct.c b/kernel/acct.c [] > > @@ -376,9 +376,8 @@ static comp2_t encode_comp2_t(u64 value) > > if (exp > MAXEXP2) { > > /* Overflow. Return largest represent

Re: [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning.

On Wed, Sep 24, 2014 at 11:13:45PM -0400, Elshad Mustafayev wrote: > Fixed a coding style issue. > > Signed-off-by: Elshad Mustafayev > --- > kernel/acct.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/acct.c b/kernel/acct.c > index b4c667d..ed4cf00 100644 >

[PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning.

Fixed a coding style issue. Signed-off-by: Elshad Mustafayev --- kernel/acct.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/acct.c b/kernel/acct.c index b4c667d..ed4cf00 100644 --- a/kernel/acct.c +++ b/kernel/acct.c @@ -376,9 +376,8 @@ static comp2_t encode_comp2