Re: [PATCH] kernel:signal.c Fix coding style errors and warnings.

2014-11-16 Thread Al Viro
On Sun, Nov 16, 2014 at 07:28:29PM +0200, Ionut Alexa wrote: > I worked a while in critical automotive software application. There is > nothing more important than to know your program is running start-to-end in > the correct order. For the automotive indurstri is safety critical. For PC > applicat

Re: [PATCH] kernel:signal.c Fix coding style errors and warnings.

2014-11-16 Thread Al Viro
On Sun, Nov 16, 2014 at 11:41:42AM +0200, Ionut Alexa wrote: > A good programming practice is to have a single exit point of the function. It is a very simplified form of something that was a a good practice until some rather important parts had been dropped. > Respecting this rule will reduce st

Re: [PATCH] kernel:signal.c Fix coding style errors and warnings.

2014-11-15 Thread Al Viro
On Fri, Nov 14, 2014 at 05:56:55PM +0200, Ionut Alexa wrote: > Fix various coding style errors and warnings as: > - space before tabs > - exiting a function from different points (else after return > ..) How the hell is that goto any better than plain return? Because

[PATCH] kernel:signal.c Fix coding style errors and warnings.

2014-11-14 Thread Ionut Alexa
Fix various coding style errors and warnings as: - space before tabs - exiting a function from different points (else after return ..) Signed-off-by: Ionut Alexa --- kernel/signal.c | 104 +-- 1 file changed, 55 i