Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL

2017-09-01 Thread Jens Axboe
On 08/30/2017 08:04 AM, Dan Carpenter wrote: > The kernfs_get_inode() returns NULL on error, it never returns error > pointers. Added for 4.14, with the ack from Tejun and Greg. -- Jens Axboe

Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL

2017-08-31 Thread Greg Kroah-Hartman
On Thu, Aug 31, 2017 at 01:56:40PM -0600, Jens Axboe wrote: > On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote: > > On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote: > >> The kernfs_get_inode() returns NULL on error, it never returns error > >> pointers. > >> > >> Fixes: aa8188253474 (

Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL

2017-08-31 Thread Jens Axboe
On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote: > On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote: >> The kernfs_get_inode() returns NULL on error, it never returns error >> pointers. >> >> Fixes: aa8188253474 ("kernfs: add exportfs operations") >> Signed-off-by: Dan Carpenter >> A

Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL

2017-08-31 Thread Greg Kroah-Hartman
On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote: > The kernfs_get_inode() returns NULL on error, it never returns error > pointers. > > Fixes: aa8188253474 ("kernfs: add exportfs operations") > Signed-off-by: Dan Carpenter > Acked-by: Tejun Heo Hm, I don't know what tree aa8188253

Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL

2017-08-30 Thread Tejun Heo
On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote: > The kernfs_get_inode() returns NULL on error, it never returns error > pointers. > > Fixes: aa8188253474 ("kernfs: add exportfs operations") > Signed-off-by: Dan Carpenter Acked-by: Tejun Heo Greg, can you please route this patch

[PATCH] kernfs: checking for IS_ERR() instead of NULL

2017-08-30 Thread Dan Carpenter
The kernfs_get_inode() returns NULL on error, it never returns error pointers. Fixes: aa8188253474 ("kernfs: add exportfs operations") Signed-off-by: Dan Carpenter diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c index 7c452f4d83e9..95a7c88baed9 100644 --- a/fs/kernfs/mount.c +++ b/fs/kernfs/m