Re: [PATCH] kernfs: fix memleak in kernel_ops_readdir()

2019-08-08 Thread Greg Kroah-Hartman
On Wed, Aug 07, 2019 at 11:45:18AM -0700, Tejun Heo wrote: > Hello, > > On Wed, Aug 07, 2019 at 06:29:28AM -0700, Tony Lindgren wrote: > > Hi, > > > > * Tejun Heo [691231 23:00]: > > > From: Andrea Arcangeli > > > > > > If getdents64 is killed or hits on segfault, it'll leave cgroups > > >

Re: [PATCH] kernfs: fix memleak in kernel_ops_readdir()

2019-08-07 Thread Tejun Heo
Hello, On Wed, Aug 07, 2019 at 06:29:28AM -0700, Tony Lindgren wrote: > Hi, > > * Tejun Heo [691231 23:00]: > > From: Andrea Arcangeli > > > > If getdents64 is killed or hits on segfault, it'll leave cgroups > > directories in sysfs pinned leaking memory because the kernfs node > > won't be

Re: [PATCH] kernfs: fix memleak in kernel_ops_readdir()

2019-08-07 Thread Tony Lindgren
Hi, * Tejun Heo [691231 23:00]: > From: Andrea Arcangeli > > If getdents64 is killed or hits on segfault, it'll leave cgroups > directories in sysfs pinned leaking memory because the kernfs node > won't be freed on rmdir and the parent neither. Somehow this causes a regression in Linux next

[PATCH] kernfs: fix memleak in kernel_ops_readdir()

2019-08-05 Thread Tejun Heo
From: Andrea Arcangeli If getdents64 is killed or hits on segfault, it'll leave cgroups directories in sysfs pinned leaking memory because the kernfs node won't be freed on rmdir and the parent neither. Repro: # for i in `seq 1000`; do mkdir $i; done # rmdir * # for i in `seq 1000`; do