Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

2005-03-10 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > > Do you want me to redo the patch? > > > > That, or a delta. At your convenience. A new patch is just as easy. There'll be one with you shortly. > What's your feeling on the stability Well... it boots:-) That involves creating and destroying keyrin

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

2005-03-10 Thread Andrew Morton
David Howells <[EMAIL PROTECTED]> wrote: > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > What's with the preempt_enable()/disable() added to __key_link()? It's not > > obvious what is being protected from what, and why. > > Ummm... Yes... They're probably not necessary. A wmb() may be require

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

2005-03-10 Thread David Howells
David Howells <[EMAIL PROTECTED]> wrote: > > What's with the preempt_enable()/disable() added to __key_link()? It's not > > obvious what is being protected from what, and why. > > Ummm... Yes... They're probably not necessary. A wmb() may be required after > the klist->nkeys++ to commit to memor

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

2005-03-10 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > What's with the preempt_enable()/disable() added to __key_link()? It's not > obvious what is being protected from what, and why. Ummm... Yes... They're probably not necessary. A wmb() may be required after the klist->nkeys++ to commit to memory the fact

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

2005-03-10 Thread Andrew Morton
David Howells <[EMAIL PROTECTED]> wrote: > > The attached patch changes the key implementation in a number of ways: That worked. What's with the preempt_enable()/disable() added to __key_link()? It's not obvious what is being protected from what, and why. - To unsubscribe from this list: send t

[PATCH] keys: Discard key spinlock and use RCU for key payload [try #2]

2005-03-09 Thread David Howells
The attached patch changes the key implementation in a number of ways: (1) It removes the spinlock from the key structure. (2) The key flags are now accessed using atomic bitops instead of write-locking the key spinlock and using C bitwise operators. The three instantiation flags ar

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload

2005-03-09 Thread David Howells
Linus Torvalds <[EMAIL PROTECTED]> wrote: > > The attached patch changes the key implementation in a number of ways: > > > > (1) It removes the spinlock from the key structure. > > > > (2) The key flags are now accessed using atomic bitops instead of > > write-locking the key spinlock and

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload

2005-03-09 Thread Linus Torvalds
On Wed, 9 Mar 2005, David Howells wrote: > > The attached patch changes the key implementation in a number of ways: > > (1) It removes the spinlock from the key structure. > > (2) The key flags are now accessed using atomic bitops instead of > write-locking the key spinlock and using C

[PATCH] keys: Discard key spinlock and use RCU for key payload

2005-03-09 Thread David Howells
The attached patch changes the key implementation in a number of ways: (1) It removes the spinlock from the key structure. (2) The key flags are now accessed using atomic bitops instead of write-locking the key spinlock and using C bitwise operators. The three instantiation flags ar