Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

Andrew Morton <[EMAIL PROTECTED]> wrote: > > Do you want me to redo the patch? > > > > That, or a delta. At your convenience. A new patch is just as easy. There'll be one with you shortly. > What's your feeling on the stability Well... it boots:-) That involves creating and destroying

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

David Howells <[EMAIL PROTECTED]> wrote: > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > What's with the preempt_enable()/disable() added to __key_link()? It's not > > obvious what is being protected from what, and why. > > Ummm... Yes... They're probably not necessary. A wmb() may be

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

David Howells <[EMAIL PROTECTED]> wrote: > > What's with the preempt_enable()/disable() added to __key_link()? It's not > > obvious what is being protected from what, and why. > > Ummm... Yes... They're probably not necessary. A wmb() may be required after > the klist->nkeys++ to commit to

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

Andrew Morton <[EMAIL PROTECTED]> wrote: > What's with the preempt_enable()/disable() added to __key_link()? It's not > obvious what is being protected from what, and why. Ummm... Yes... They're probably not necessary. A wmb() may be required after the klist->nkeys++ to commit to memory the

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

David Howells <[EMAIL PROTECTED]> wrote: > > The attached patch changes the key implementation in a number of ways: That worked. What's with the preempt_enable()/disable() added to __key_link()? It's not obvious what is being protected from what, and why. - To unsubscribe from this list: send

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

David Howells [EMAIL PROTECTED] wrote: The attached patch changes the key implementation in a number of ways: That worked. What's with the preempt_enable()/disable() added to __key_link()? It's not obvious what is being protected from what, and why. - To unsubscribe from this list: send the

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

Andrew Morton [EMAIL PROTECTED] wrote: What's with the preempt_enable()/disable() added to __key_link()? It's not obvious what is being protected from what, and why. Ummm... Yes... They're probably not necessary. A wmb() may be required after the klist-nkeys++ to commit to memory the fact

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

David Howells [EMAIL PROTECTED] wrote: What's with the preempt_enable()/disable() added to __key_link()? It's not obvious what is being protected from what, and why. Ummm... Yes... They're probably not necessary. A wmb() may be required after the klist-nkeys++ to commit to memory the

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

David Howells [EMAIL PROTECTED] wrote: Andrew Morton [EMAIL PROTECTED] wrote: What's with the preempt_enable()/disable() added to __key_link()? It's not obvious what is being protected from what, and why. Ummm... Yes... They're probably not necessary. A wmb() may be required after the

Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

Andrew Morton [EMAIL PROTECTED] wrote: Do you want me to redo the patch? That, or a delta. At your convenience. A new patch is just as easy. There'll be one with you shortly. What's your feeling on the stability Well... it boots:-) That involves creating and destroying keyrings and