Re: [PATCH] keys: Move permissions checking decisions into the checking code

2020-05-15 Thread David Howells
Stephen Smalley wrote: > > I can go back to the enum patch for the moment if you and Casey can put up > > with that for the moment? > > Yes, let's do that. Okay. I'll use the attached. I've added a note into the commit message to indicate what should be done in future. I won't put the other

Re: [PATCH] keys: Move permissions checking decisions into the checking code

2020-05-15 Thread Casey Schaufler
On 5/15/2020 11:55 AM, Stephen Smalley wrote: > On Fri, May 15, 2020 at 12:45 PM David Howells wrote: >> I can go back to the enum patch for the moment if you and Casey can put up >> with that for the moment? > Yes, let's do that. OK by me.

Re: [PATCH] keys: Move permissions checking decisions into the checking code

2020-05-15 Thread Stephen Smalley
On Fri, May 15, 2020 at 12:45 PM David Howells wrote: > I can go back to the enum patch for the moment if you and Casey can put up > with that for the moment? Yes, let's do that.

Re: [PATCH] keys: Move permissions checking decisions into the checking code

2020-05-15 Thread David Howells
Stephen Smalley wrote: > > (1) KEY_FLAG_KEEP in key->flags - The key may not be deleted and/or > > things > > may not be removed from the keyring. > > Why can't they be deleted / removed? They can't ever be deleted or > removed or for some period of time? This is only settable i

Re: [PATCH] keys: Move permissions checking decisions into the checking code

2020-05-15 Thread Stephen Smalley
On Thu, May 14, 2020 at 12:59 PM David Howells wrote: > > How about this then? > > David > --- > commit fa37b6c7e2f86d16ede1e0e3cb73857152d51825 > Author: David Howells > Date: Thu May 14 17:48:55 2020 +0100 > > keys: Move permissions checking decisions into the checking code > > Overha

Re: [PATCH] keys: Move permissions checking decisions into the checking code

2020-05-14 Thread Casey Schaufler
On 5/14/2020 9:58 AM, David Howells wrote: > How about this then? > > David > --- > commit fa37b6c7e2f86d16ede1e0e3cb73857152d51825 > Author: David Howells > Date: Thu May 14 17:48:55 2020 +0100 > > keys: Move permissions checking decisions into the checking code > > Overhaul the pe

[PATCH] keys: Move permissions checking decisions into the checking code

2020-05-14 Thread David Howells
How about this then? David --- commit fa37b6c7e2f86d16ede1e0e3cb73857152d51825 Author: David Howells Date: Thu May 14 17:48:55 2020 +0100 keys: Move permissions checking decisions into the checking code Overhaul the permissions checking, moving the decisions of which permits to