Re: [PATCH] kill DECLARE_MUTEX_LOCKED

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 10:58:34 +0530 "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > Well, probably not worth much, but: Ack. um. The time and effort which you put into reviewing a patch pretty much directly subtracts from the time and effort which I need to put into doing the same. So: worth lots t

Re: [PATCH] kill DECLARE_MUTEX_LOCKED

2007-07-20 Thread Satyam Sharma
Hi, On 7/20/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: On Fri, Jul 20, 2007 at 10:58:34AM +0530, Satyam Sharma wrote: > That comment in libusual is quite nonsensical, IMHO. Note that > usu_init_notify is declared as DECLARE_MUTEX_LOCKED and yet the > author wants us to believe (later, when

Re: [PATCH] kill DECLARE_MUTEX_LOCKED

2007-07-20 Thread Christoph Hellwig
On Fri, Jul 20, 2007 at 10:58:34AM +0530, Satyam Sharma wrote: > That comment in libusual is quite nonsensical, IMHO. Note that > usu_init_notify is declared as DECLARE_MUTEX_LOCKED and yet the > author wants us to believe (later, when he's doing that dummy Given that no one should use libusual an

Re: [PATCH] kill DECLARE_MUTEX_LOCKED

2007-07-19 Thread Satyam Sharma
Hi Christoph, On 7/20/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: DECLARE_MUTEX_LOCKED was used for semaphores used as completions and we've got rid of them. Thanks, I'd been meaning to do this for months :-) Had even audited the kernel for its usage ... just didn't make or send out a pat

[PATCH] kill DECLARE_MUTEX_LOCKED

2007-07-19 Thread Christoph Hellwig
DECLARE_MUTEX_LOCKED was used for semaphores used as completions and we've got rid of them. Well, except for one in libusual that the maintainer explicitly wants to keep as semaphore. So convert that useage to an explicit sema_init and kill of DECLARE_MUTEX_LOCKED so that new code is reminded to