Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-31 Thread Tariq Toukan
On 31/12/2017 12:39 PM, Greg Kroah-Hartman wrote: On Sun, Dec 31, 2017 at 12:28:02PM +0200, Tariq Toukan wrote: On 21/12/2017 7:13 AM, Dmitry Torokhov wrote: Greg, can you please schedule my patch in for 4.15? We must have it in, otherwise there will be a major degradation (many driver

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-31 Thread Greg Kroah-Hartman
On Sun, Dec 31, 2017 at 12:28:02PM +0200, Tariq Toukan wrote: > > > On 21/12/2017 7:13 AM, Dmitry Torokhov wrote: > > Greg, > > can you please schedule my patch in for 4.15? > > > > We must have it in, otherwise there will be a major degradation (many > drivers won't be able to reload). > Greg

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-31 Thread Tariq Toukan
On 21/12/2017 7:13 AM, Dmitry Torokhov wrote: Greg, can you please schedule my patch in for 4.15? We must have it in, otherwise there will be a major degradation (many drivers won't be able to reload). Greg?

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-27 Thread Casey Leedom
Dmitry, Komali has done some experiments with changing /lib/udev/rules.d/80-drivers.rules along the lines you suggested and that seems to be the trick (I'm waiting for clarification from her). What's the mechanism for getting that change committed to the various repositories? Also, your fi

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-21 Thread Casey Leedom
| From: Dmitry Torokhov | Sent: Wednesday, December 20, 2017 9:13 PM | | The 2nd issue is that Casey is seeing cxgb4vf driver being loaded. | This happens because vfio-pci driver binds to the device, which causes | KOBJ_BIND to get emitted, which causes all modules that match the PCI | device ID t

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-20 Thread Dmitry Torokhov
On Tue, Dec 19, 2017 at 3:20 PM, Casey Leedom wrote: > By the way, Komali went back and tried 4.14.7 and it does exhibit the > issue which she originally reported. As noted before, the origin of the new > behavior was tracked down to kernel.org:1455cf8 ... Also as noted, Dmitry's > patch does

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-19 Thread Casey Leedom
By the way, Komali went back and tried 4.14.7 and it does exhibit the issue which she originally reported. As noted before, the origin of the new behavior was tracked down to kernel.org:1455cf8 ... Also as noted, Dmitry's patch does not solve the problem. Casey

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-19 Thread Tariq Toukan
On 19/12/2017 11:12 AM, Eric Dumazet wrote: On Tue, Dec 19, 2017 at 12:48 AM, Greg Kroah-Hartman wrote: On Wed, Dec 13, 2017 at 03:21:22PM -0800, Dmitry Torokhov wrote: The commit 4a336a23d619 ("kobject: copy env blob in one go") optimized constructing uevent data for delivery over netlink b

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-19 Thread Eric Dumazet
On Tue, Dec 19, 2017 at 12:48 AM, Greg Kroah-Hartman wrote: > On Wed, Dec 13, 2017 at 03:21:22PM -0800, Dmitry Torokhov wrote: >> The commit 4a336a23d619 ("kobject: copy env blob in one go") optimized >> constructing uevent data for delivery over netlink by using the raw >> environment buffer, ins

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-19 Thread Greg Kroah-Hartman
On Wed, Dec 13, 2017 at 03:21:22PM -0800, Dmitry Torokhov wrote: > The commit 4a336a23d619 ("kobject: copy env blob in one go") optimized > constructing uevent data for delivery over netlink by using the raw > environment buffer, instead of reconstructing it from individual > environment pointers.

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-18 Thread Casey Leedom
By the way, Komali just reported another bug internally where instantiating an SR-IOV Virtual Function causes cxgb4vf to be automatically loaded, which is normal behavior. But then when she attempts to unload cxgb4vf, it simply gets reloaded again. This is with: [root@t5nic linux]# git sh

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-18 Thread Casey Leedom
/ From: Casey Leedom | Date: Friday, December 15, 2017 11:17 PST | | | From: Dmitry Torokhov | | Sent: Friday, December 15, 2017 10:53 AM | | | | Hmm, can she collect output of 'udevadm monitor -p' at the time you | | assign the adapter to the VM? | | Sure. I'll have Komali report on that.

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-17 Thread Tariq Toukan
On 17/12/2017 5:29 PM, Tariq Toukan wrote: On 14/12/2017 10:32 PM, Dmitry Torokhov wrote: On Thu, Dec 14, 2017 at 12:15 PM, Casey Leedom wrote:    Thanks Dmitry!  I've asked Komali to test it against the problem that she reported internally.  She or I will get back to you on that testing

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-17 Thread Tariq Toukan
On 14/12/2017 10:32 PM, Dmitry Torokhov wrote: On Thu, Dec 14, 2017 at 12:15 PM, Casey Leedom wrote: Thanks Dmitry! I've asked Komali to test it against the problem that she reported internally. She or I will get back to you on that testing ASAP. I see that we've now moved on to 4.1

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-15 Thread Casey Leedom
| From: Dmitry Torokhov | Sent: Friday, December 15, 2017 10:53 AM | | Hmm, can she collect output of 'udevadm monitor -p' at the time you | assign the adapter to the VM? Sure. I'll have Komali report on that. | Also, do you have any udev rules that is specific to cxgb? Or any other | custom u

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-15 Thread Dmitry Torokhov
On Fri, Dec 15, 2017 at 10:17 AM, Casey Leedom wrote: > Hi Dmitry, > > Komali reports that she still sees the originally reported issue with your > latest patch. This issue started with kernel.org commit > 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 (Wed Jul 19 17:24:30 2017 -0700). > > cxgb4vf

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-15 Thread Casey Leedom
Hi Dmitry, Komali reports that she still sees the originally reported issue with your latest patch. This issue started with kernel.org commit 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 (Wed Jul 19 17:24:30 2017 -0700). cxgb4vf is getting loaded in the Hypervisor when a cxgb4 Virtual Function i

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-14 Thread Casey Leedom
  Ah, okay, I see.  So it's been getting "broken" and "fixed" for the last six months or so ... :-)  I think it's still broken in the latest 4.14.6 but I'll have to check with Komali on that. I'm not 100% sure it's important enough to push back into 4.14.{x} if it is still broken there ... Ca

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-14 Thread Dmitry Torokhov
On Thu, Dec 14, 2017 at 1:38 PM, Casey Leedom wrote: > | From: Dmitry Torokhov > | Sent: Thursday, December 14, 2017 12:32 PM > | > | As far as I can see Eric's patch is landed in 4.15-rc1 so I do not > | think we need this patch in .14. > > Except that Komali's bisect showed that the bug occur

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-14 Thread Casey Leedom
| From: Dmitry Torokhov | Sent: Thursday, December 14, 2017 12:32 PM | | As far as I can see Eric's patch is landed in 4.15-rc1 so I do not | think we need this patch in .14. Except that Komali's bisect showed that the bug occured with kernel.org: 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 which

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-14 Thread Dmitry Torokhov
On Thu, Dec 14, 2017 at 12:15 PM, Casey Leedom wrote: > Thanks Dmitry! I've asked Komali to test it against the problem that she > reported internally. She or I will get back to you on that testing ASAP. > > I see that we've now moved on to 4.15 and the problem first showed up in > 4.14.

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-14 Thread Casey Leedom
Thanks Dmitry! I've asked Komali to test it against the problem that she reported internally. She or I will get back to you on that testing ASAP. I see that we've now moved on to 4.15 and the problem first showed up in 4.14. Once the fix is verified, should we see if it can get pushed bac

[PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

2017-12-13 Thread Dmitry Torokhov
The commit 4a336a23d619 ("kobject: copy env blob in one go") optimized constructing uevent data for delivery over netlink by using the raw environment buffer, instead of reconstructing it from individual environment pointers. Unfortunately in doing so it broke suppressing MODALIAS attribute for KOB