Re: [PATCH] kprobes: Allow kprobes coexist with livepatch

2019-07-27 Thread Masami Hiramatsu
On Fri, 26 Jul 2019 13:38:41 -0400 Joe Lawrence wrote: > On 7/26/19 12:14 PM, Steven Rostedt wrote: > > On Thu, 25 Jul 2019 22:07:52 -0400 > > Joe Lawrence wrote: > > > >> These results reflect my underestanding of FTRACE_OPS_FL_IPMODIFY in > >> light of your changes, so feel free to add my: >

Re: [PATCH] kprobes: Allow kprobes coexist with livepatch

2019-07-26 Thread Steven Rostedt
On Fri, 26 Jul 2019 13:38:41 -0400 Joe Lawrence wrote: > On 7/26/19 12:14 PM, Steven Rostedt wrote: > > On Thu, 25 Jul 2019 22:07:52 -0400 > > Joe Lawrence wrote: > > > >> These results reflect my underestanding of FTRACE_OPS_FL_IPMODIFY in > >> light of your changes, so feel free to add my:

Re: [PATCH] kprobes: Allow kprobes coexist with livepatch

2019-07-26 Thread Joe Lawrence
On 7/26/19 12:14 PM, Steven Rostedt wrote: On Thu, 25 Jul 2019 22:07:52 -0400 Joe Lawrence wrote: These results reflect my underestanding of FTRACE_OPS_FL_IPMODIFY in light of your changes, so feel free to add my: Acked-by: Joe Lawrence Is this an urgent patch (needs to go in now and not

Re: [PATCH] kprobes: Allow kprobes coexist with livepatch

2019-07-26 Thread Steven Rostedt
On Thu, 25 Jul 2019 22:07:52 -0400 Joe Lawrence wrote: > These results reflect my underestanding of FTRACE_OPS_FL_IPMODIFY in > light of your changes, so feel free to add my: > > Acked-by: Joe Lawrence Is this an urgent patch (needs to go in now and not wait for the next merge window) and if

Re: [PATCH] kprobes: Allow kprobes coexist with livepatch

2019-07-25 Thread Joe Lawrence
On Thu, Jul 25, 2019 at 03:24:37PM +0900, Masami Hiramatsu wrote: > Allow kprobes which do not modify regs->ip, coexist with livepatch > by dropping FTRACE_OPS_FL_IPMODIFY from ftrace_ops. > > User who wants to modify regs->ip (e.g. function fault injection) > must set a dummy post_handler to its

Re: [PATCH] kprobes: Allow kprobes coexist with livepatch

2019-07-25 Thread Steven Rostedt
On Thu, 25 Jul 2019 15:24:37 +0900 Masami Hiramatsu wrote: > Allow kprobes which do not modify regs->ip, coexist with livepatch > by dropping FTRACE_OPS_FL_IPMODIFY from ftrace_ops. > > User who wants to modify regs->ip (e.g. function fault injection) > must set a dummy post_handler to its

[PATCH] kprobes: Allow kprobes coexist with livepatch

2019-07-25 Thread Masami Hiramatsu
Allow kprobes which do not modify regs->ip, coexist with livepatch by dropping FTRACE_OPS_FL_IPMODIFY from ftrace_ops. User who wants to modify regs->ip (e.g. function fault injection) must set a dummy post_handler to its kprobes when registering. However, if such regs->ip modifying kprobes is