Re: [PATCH] kprobes: remove sparse warnings from x86

2008-02-17 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > Ingo, could you take this in x86.git? yeah - and Thomas has beaten me at picking it up :-) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] kprobes: remove sparse warnings from x86

2008-02-14 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > > > > It looks good to me. > > > > Acked-by: Masami Hiramatsu <[EMAIL PROTECTED]> > > > > Thank you, > > Ingo, could you take this in x86.git? thanks Harvey, applied. Ingo -- To u

Re: [PATCH] kprobes: remove sparse warnings from x86

2008-02-14 Thread Harvey Harrison
It looks good to me. > > Acked-by: Masami Hiramatsu <[EMAIL PROTECTED]> > > Thank you, > Ingo, could you take this in x86.git? Harvey From: Harvey Harrison <[EMAIL PROTECTED]> Subject: [PATCH] kprobes: remove sparse warnings from x86 arch/x86/kernel/

Re: [PATCH] kprobes: remove sparse warnings from x86

2008-02-14 Thread Masami Hiramatsu
Harvey Harrison : > arch/x86/kernel/kprobes.c:584:16: warning: symbol > 'kretprobe_trampoline_holder' was not declared. Should it be static? > arch/x86/kernel/kprobes.c:676:6: warning: symbol 'trampoline_handler' was not > declared. Should it be static? > > Make them static and add the __used at

[PATCH] kprobes: remove sparse warnings from x86

2008-02-13 Thread Harvey Harrison
arch/x86/kernel/kprobes.c:584:16: warning: symbol 'kretprobe_trampoline_holder' was not declared. Should it be static? arch/x86/kernel/kprobes.c:676:6: warning: symbol 'trampoline_handler' was not declared. Should it be static? Make them static and add the __used attribute, approach taken from t