Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Aleksa Sarai
On 2018-11-02, Masami Hiramatsu wrote: > On Thu, 1 Nov 2018 21:49:48 +1100 > Aleksa Sarai wrote: > > > On 2018-11-01, Masami Hiramatsu wrote: > > > > > > Anyway, until that merge happens, this patch looks good to avoid > > > > > > this issue for generic solution (e.g. for the arch which

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Aleksa Sarai
On 2018-11-02, Masami Hiramatsu wrote: > On Thu, 1 Nov 2018 21:49:48 +1100 > Aleksa Sarai wrote: > > > On 2018-11-01, Masami Hiramatsu wrote: > > > > > > Anyway, until that merge happens, this patch looks good to avoid > > > > > > this issue for generic solution (e.g. for the arch which

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Masami Hiramatsu
On Thu, 1 Nov 2018 21:49:48 +1100 Aleksa Sarai wrote: > On 2018-11-01, Masami Hiramatsu wrote: > > > > > Anyway, until that merge happens, this patch looks good to avoid > > > > > this issue for generic solution (e.g. for the arch which doesn't > > > > > supports retstack). > > > > > > > > I

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Masami Hiramatsu
On Thu, 1 Nov 2018 21:49:48 +1100 Aleksa Sarai wrote: > On 2018-11-01, Masami Hiramatsu wrote: > > > > > Anyway, until that merge happens, this patch looks good to avoid > > > > > this issue for generic solution (e.g. for the arch which doesn't > > > > > supports retstack). > > > > > > > > I

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Steven Rostedt
On Thu, 1 Nov 2018 21:49:48 +1100 Aleksa Sarai wrote: > > > Should I continue working on this patchset? > > > > Yes, until we finally introduce Steven's algorithm on all arch (yeah, we > > still > > have some archs which don't support graph-tracer but supports kprobes), > > I think your

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Steven Rostedt
On Thu, 1 Nov 2018 21:49:48 +1100 Aleksa Sarai wrote: > > > Should I continue working on this patchset? > > > > Yes, until we finally introduce Steven's algorithm on all arch (yeah, we > > still > > have some archs which don't support graph-tracer but supports kprobes), > > I think your

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Aleksa Sarai
On 2018-11-01, Masami Hiramatsu wrote: > > > > Anyway, until that merge happens, this patch looks good to avoid > > > > this issue for generic solution (e.g. for the arch which doesn't > > > > supports retstack). > > > > > > I think its time to come up with an algorithm that makes function graph

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Aleksa Sarai
On 2018-11-01, Masami Hiramatsu wrote: > > > > Anyway, until that merge happens, this patch looks good to avoid > > > > this issue for generic solution (e.g. for the arch which doesn't > > > > supports retstack). > > > > > > I think its time to come up with an algorithm that makes function graph

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Masami Hiramatsu
On Thu, 1 Nov 2018 00:39:12 +1100 Aleksa Sarai wrote: > On 2018-10-31, Steven Rostedt wrote: > > > Anyway, until that merge happens, this patch looks good to avoid > > > this issue for generic solution (e.g. for the arch which doesn't > > > supports retstack). > > > > I think its time to come

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Masami Hiramatsu
On Thu, 1 Nov 2018 00:39:12 +1100 Aleksa Sarai wrote: > On 2018-10-31, Steven Rostedt wrote: > > > Anyway, until that merge happens, this patch looks good to avoid > > > this issue for generic solution (e.g. for the arch which doesn't > > > supports retstack). > > > > I think its time to come

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Masami Hiramatsu
On Tue, 30 Oct 2018 14:19:53 +1100 Aleksa Sarai wrote: > On 2018-10-30, Masami Hiramatsu wrote: > > > Historically, kretprobe has always produced unusable stack traces > > > (kretprobe_trampoline is the only entry in most cases, because of the > > > funky stack pointer overwriting). This has

Re: [PATCH] kretprobe: produce sane stack traces

2018-11-01 Thread Masami Hiramatsu
On Tue, 30 Oct 2018 14:19:53 +1100 Aleksa Sarai wrote: > On 2018-10-30, Masami Hiramatsu wrote: > > > Historically, kretprobe has always produced unusable stack traces > > > (kretprobe_trampoline is the only entry in most cases, because of the > > > funky stack pointer overwriting). This has

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-31 Thread Aleksa Sarai
On 2018-10-31, Steven Rostedt wrote: > > Anyway, until that merge happens, this patch looks good to avoid > > this issue for generic solution (e.g. for the arch which doesn't > > supports retstack). > > I think its time to come up with an algorithm that makes function graph > work with multiple

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-31 Thread Aleksa Sarai
On 2018-10-31, Steven Rostedt wrote: > > Anyway, until that merge happens, this patch looks good to avoid > > this issue for generic solution (e.g. for the arch which doesn't > > supports retstack). > > I think its time to come up with an algorithm that makes function graph > work with multiple

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-31 Thread Steven Rostedt
On Tue, 30 Oct 2018 10:12:06 +0900 Masami Hiramatsu wrote: > Anyway, until that merge happens, this patch looks good to avoid > this issue for generic solution (e.g. for the arch which doesn't > supports retstack). I think its time to come up with an algorithm that makes function graph work

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-31 Thread Steven Rostedt
On Tue, 30 Oct 2018 10:12:06 +0900 Masami Hiramatsu wrote: > Anyway, until that merge happens, this patch looks good to avoid > this issue for generic solution (e.g. for the arch which doesn't > supports retstack). I think its time to come up with an algorithm that makes function graph work

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-29 Thread Aleksa Sarai
On 2018-10-30, Masami Hiramatsu wrote: > > Historically, kretprobe has always produced unusable stack traces > > (kretprobe_trampoline is the only entry in most cases, because of the > > funky stack pointer overwriting). This has caused quite a few annoyances > > when using tracing to debug

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-29 Thread Aleksa Sarai
On 2018-10-30, Masami Hiramatsu wrote: > > Historically, kretprobe has always produced unusable stack traces > > (kretprobe_trampoline is the only entry in most cases, because of the > > funky stack pointer overwriting). This has caused quite a few annoyances > > when using tracing to debug

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-29 Thread Masami Hiramatsu
Hi Aleksa, On Sat, 27 Oct 2018 00:22:10 +1100 Aleksa Sarai wrote: > Historically, kretprobe has always produced unusable stack traces > (kretprobe_trampoline is the only entry in most cases, because of the > funky stack pointer overwriting). This has caused quite a few annoyances > when using

Re: [PATCH] kretprobe: produce sane stack traces

2018-10-29 Thread Masami Hiramatsu
Hi Aleksa, On Sat, 27 Oct 2018 00:22:10 +1100 Aleksa Sarai wrote: > Historically, kretprobe has always produced unusable stack traces > (kretprobe_trampoline is the only entry in most cases, because of the > funky stack pointer overwriting). This has caused quite a few annoyances > when using

[PATCH] kretprobe: produce sane stack traces

2018-10-26 Thread Aleksa Sarai
Historically, kretprobe has always produced unusable stack traces (kretprobe_trampoline is the only entry in most cases, because of the funky stack pointer overwriting). This has caused quite a few annoyances when using tracing to debug problems[1] -- since return values are only available with

[PATCH] kretprobe: produce sane stack traces

2018-10-26 Thread Aleksa Sarai
Historically, kretprobe has always produced unusable stack traces (kretprobe_trampoline is the only entry in most cases, because of the funky stack pointer overwriting). This has caused quite a few annoyances when using tracing to debug problems[1] -- since return values are only available with